feat(dashboard,core-flows,js-sdk,types): ability to mark payment as paid #8679
Conversation
Co-authored-by: Carlos R. L. Rodrigues <37986729+carlos-r-l-rodrigues@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
riqwan
requested review from
sradevski,
christiananese,
olivermrbl and
carlos-r-l-rodrigues
and removed request for
a team
packages/core/core-flows/src/order/workflows/mark-payment-collection-as-paid.ts
Outdated
Show resolved
Hide resolved
riqwan
changed the base branch from
feat/create-or-update-payment-collection
to
develop
riqwan
force-pushed
the
feat/mark-as-paid
branch
from
021d9b3 to
97ad6f9
Compare
|
You can only mark system payments as paid, correct? |
|
@olivermrbl yes, thats correct. Did I miss something? |
| @@ -104,10 +110,54 @@ export const OrderSummarySection = ({ order }: OrderSummarySectionProps) => { | |||
| (pc) => pc.status === "not_paid" | |||
There was a problem hiding this comment.
question: Can we rely on this check? couldn't there be multiple unpaid collections?
There was a problem hiding this comment.
There's no way to get in this situation through the UI as of yet. So not possible right now. But when we link the payment collection to the order change, we can get rid of this check
No no, I am just trying to wrap my head around how this will work with other payment collections on the order 😄 |
what:
markaspaid.mp4