Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-flows): account for unfulfilled items while generating order status #8698

Merged
merged 6 commits into from
Aug 21, 2024
Merged

fix(core-flows): account for unfulfilled items while generating order status #8698

merged 6 commits into from
Aug 21, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Aug 21, 2024

what:

  • account for unfulfilled items while generating order status

RESOLVES CC-314

@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 2:21pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 21, 2024 2:21pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 2:21pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 2:21pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 2:21pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 2:21pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 2:21pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 31ad67d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan force-pushed the feat/order-status branch from 2274909 to 4450e82 Compare August 21, 2024 13:18
@riqwan riqwan force-pushed the feat/order-status branch from 4450e82 to de778fb Compare August 21, 2024 13:19
@riqwan riqwan marked this pull request as ready for review August 21, 2024 13:19
@riqwan riqwan requested a review from a team as a code owner August 21, 2024 13:19
carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/core/core-flows/src/order/utils/aggregate-status.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/order/utils/aggregate-status.ts Outdated Show resolved Hide resolved
@riqwan @carlos-r-l-rodrigues
Apply suggestions from code review
8762139 
Co-authored-by: Carlos R. L. Rodrigues <37986729+carlos-r-l-rodrigues@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit de7848f into develop Aug 21, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/order-status branch August 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riqwan @carlos-r-l-rodrigues