Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: product category types #8833

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: product category types #8833

merged 1 commit into from
Aug 28, 2024

Conversation

Alexnortung
Copy link
Contributor

This PR fixes the things that was discussed in #8766

@Alexnortung Alexnortung requested a review from a team as a code owner August 28, 2024 07:25
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 340f28b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024

@Alexnortung is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

olivermrbl
olivermrbl approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Alexnortung

riqwan
riqwan approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend!

@olivermrbl olivermrbl merged commit afd6fdc into medusajs:develop Aug 28, 2024
14 of 22 checks passed
@Alexnortung Alexnortung deleted the fix/product-category branch August 28, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan riqwan approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexnortung @riqwan @olivermrbl