Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for providers to validate their options at loading time #8853

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Aug 28, 2024

RESOLVES FRMW-2679

What

  • Add new static validateOptions method to all providers abstract class with a default implementation (do nothing).
  • This pr add the Implementation of the validation to the different providers that currently validate their options.
  • The provider loader once it has discovered the providers classes and before registering it in the container, will call the static validation method to validate the options and throw otherwise.

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 4:50pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 28, 2024 4:50pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 4:50pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 4:50pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 4:50pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 4:50pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 4:50pm

Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 2f24f08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

olivermrbl
olivermrbl previously approved these changes Aug 28, 2024
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@olivermrbl olivermrbl dismissed their stale review August 28, 2024 14:56

sorry, I clicked the approval button a little too fast – noticed its still in draft

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, I can do it! 😄

@adrien2p
Copy link
Member Author

Now, I can do it! 😄

Perfect timing now 👌

@olivermrbl olivermrbl merged commit 77b874f into develop Aug 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants