Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle case where product to be updated does not exist #8897

Merged
merged 7 commits into from
Sep 2, 2024
Merged

fix: handle case where product to be updated does not exist #8897

merged 7 commits into from
Sep 2, 2024

Conversation

thetutlage
Copy link
Contributor

@thetutlage thetutlage commented Aug 30, 2024 •
edited
Loading

Fixes: FRMW-2680

Checking the product to exist before calling the workflow to update it.

@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 10:41am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 10:41am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 10:41am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 10:41am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 10:41am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 10:41am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 10:41am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 10a8ab3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thetutlage thetutlage marked this pull request as ready for review September 2, 2024 05:46
@thetutlage thetutlage requested a review from a team as a code owner September 2, 2024 05:46
adrien2p
adrien2p approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree with stev on the comment, LGTM otherwise

@thetutlage
Copy link
Contributor Author

@olivermrbl Should I go ahead and update all the UPDATE routes? The issue persists with almost every route with the same or a slightly different behavior.

@thetutlage
Copy link
Contributor Author

Added the same check to all problematic routes.

@thetutlage thetutlage merged commit 0ce5840 into develop Sep 2, 2024
23 checks passed
@thetutlage thetutlage deleted the fix/handle-missing-resource branch September 2, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan riqwan approved these changes

@adrien2p adrien2p adrien2p approved these changes

@sradevski sradevski sradevski approved these changes

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thetutlage @sradevski @riqwan @adrien2p @olivermrbl