Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notification): Handle long running transaction and add status support #8900

Merged
merged 12 commits into from
Sep 1, 2024
Merged

feat(notification): Handle long running transaction and add status support #8900

merged 12 commits into from
Sep 1, 2024

Conversation

adrien2p
Copy link
Member

RESOLVES FRMW-2110
RESOLVES FRMW-2095

What

  • Fix notification module to not retain transactions open while sending notification
  • Add support for notification status [success, pending, failure]

@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2024 7:54am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 1, 2024 7:54am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2024 7:54am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2024 7:54am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2024 7:54am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2024 7:54am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2024 7:54am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 65df5ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review August 30, 2024 10:20
@adrien2p adrien2p requested a review from a team as a code owner August 30, 2024 10:20
@adrien2p adrien2p requested a review from sradevski August 30, 2024 10:20
@adrien2p adrien2p changed the title Fix/notification long running tx feat(notification): Handle long running transaction and add status support Aug 30, 2024
sradevski
sradevski approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@kodiakhq kodiakhq bot merged commit 99461e2 into develop Sep 1, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/notification-long-running-tx branch September 1, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@sradevski sradevski sradevski approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: bug type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrien2p @sradevski @carlos-r-l-rodrigues @olivermrbl