-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): allow custom shopping prices for claims/exchanges #8912
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
A couple of comments:
- Do we want to have a dedicated custom price removal func?
- Or do we just expect the merchant to re-enter the original price, if they regret setting a custom one?
- Should we default to the price of the shipping? Otherwise, if you click to set custom price and remove focus, it will be set to 0. I don't think that's a good default behavior.
Yes, but it requires changes on the BD, I opened a ticket for that (CC-402). I believe it's in. progress.
Yup good point. I will add a fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
CLOSES CC-369