Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): allow custom shopping prices for claims/exchanges #8912

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Aug 30, 2024

What

  • add editing custom shipping price for claims and exchanges

CLOSES CC-369

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 6:40am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 2, 2024 6:40am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 6:40am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 6:40am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 6:40am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 6:40am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 6:40am

Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: d11b585

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

A couple of comments:

  • Do we want to have a dedicated custom price removal func?
    • Or do we just expect the merchant to re-enter the original price, if they regret setting a custom one?
  • Should we default to the price of the shipping? Otherwise, if you click to set custom price and remove focus, it will be set to 0. I don't think that's a good default behavior.

@fPolic
Copy link
Contributor Author

fPolic commented Sep 1, 2024

Do we want to have a dedicated custom price removal func? Or do we just expect the merchant to re-enter the original price, if they regret setting a custom one?

Yes, but it requires changes on the BD, I opened a ticket for that (CC-402). I believe it's in. progress.

Should we default to the price of the shipping? Otherwise, if you click to set custom price and remove focus, it will be set to 0. I don't think that's a good default behavior.

Yup good point. I will add a fix.

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 6652db4 into develop Sep 3, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/edit-outbound-pricing branch September 3, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants