feat(core-flows,types): Refunds can only be performed when order is imbalanced #8944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
|
riqwan
requested review from
sradevski,
carlos-r-l-rodrigues,
kasperkristensen and
olivermrbl
olivermrbl
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Overall LGTM, should be good to merge, but would be good to have @carlos-r-l-rodrigues eyes on it as well
packages/core/core-flows/src/payment/workflows/refund-payment.ts
Outdated
Show resolved
Hide resolved
packages/core/core-flows/src/payment/workflows/refund-payment.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com>
riqwan
force-pushed
the
feat/constrain-refunds
branch
from
d7117be to
886a006
Compare
carlos-r-l-rodrigues
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what:
Due to the fact that any adhoc refunds cause an imbalance in the order totals, we constrain the refunds to only be performed when there is an outstanding balance in the order
RESOLVES CC-412