Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reset password #8962

Merged
merged 18 commits into from
Sep 6, 2024
Merged

feat: Reset password #8962

merged 18 commits into from
Sep 6, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Sep 3, 2024 •
edited
Loading

Generate reset password token:

  • POST /auth/user/emailpass/reset-password { identifier: "oli@oli.com" }
  • Execute generateResetPasswordToken workflow
    • Call generateToken
    • Emit event with token
  • Respond with 201 CREATED

Reset password:

  • POST /auth/user/emailpass/update?token="..." { email: "oli@oli.com", password: "***" }
  • Validate token in middleware
  • Call authModule.updateProvider
  • Call authProvider.update
    • Hash new password
    • Update provider identity with new hashed password
  • Respond with 200

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 9:59am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 6, 2024 9:59am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 9:59am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 9:59am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 9:59am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 9:59am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 9:59am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b868e59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

olivermrbl
olivermrbl commented Sep 3, 2024
View reviewed changes
integration-tests/http/__tests__/auth/admin/auth.spec.ts
adminHeaders
)
).data.invite
describe("Full authentication lifecycle", () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are existing tests

olivermrbl
olivermrbl commented Sep 3, 2024
View reviewed changes
integration-tests/http/__tests__/auth/admin/auth.spec.ts
const signup = await api
.post("/auth/user/emailpass/register", {
email: "admin@medusa.js",
describe("Reset password flows", () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are new tests

olivermrbl
olivermrbl commented Sep 3, 2024
View reviewed changes
packages/core/core-flows/src/auth/steps/validate-reset-password-token.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/auth/workflows/reset-password.ts Outdated Show resolved Hide resolved
packages/core/utils/src/auth/abstract-auth-provider.ts Outdated Show resolved Hide resolved
packages/core/utils/src/core-flows/events.ts Outdated Show resolved Hide resolved
packages/medusa/src/api/auth/[actor_type]/[auth_provider]/reset-password/route.ts Outdated Show resolved Hide resolved
packages/medusa/src/api/auth/[actor_type]/[auth_provider]/reset-password/route.ts Outdated Show resolved Hide resolved
packages/medusa/src/api/utils/unless-path.ts Outdated Show resolved Hide resolved
packages/modules/providers/auth-emailpass/src/services/emailpass.ts Outdated Show resolved Hide resolved
riqwan
riqwan reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, added some questions/suggestions

integration-tests/http/__tests__/auth/admin/auth.spec.ts Outdated Show resolved Hide resolved
packages/core/types/src/auth/provider.ts Outdated Show resolved Hide resolved
packages/modules/providers/auth-emailpass/src/services/emailpass.ts Outdated Show resolved Hide resolved
@olivermrbl olivermrbl changed the title Feat/reset password [WIP] Feat/reset password Sep 3, 2024
@olivermrbl olivermrbl changed the title [WIP] Feat/reset password feat: Reset password Sep 6, 2024
@olivermrbl olivermrbl marked this pull request as ready for review September 6, 2024 06:51
@olivermrbl olivermrbl requested a review from a team as a code owner September 6, 2024 06:52
@olivermrbl olivermrbl marked this pull request as draft September 6, 2024 07:45
@olivermrbl olivermrbl marked this pull request as ready for review September 6, 2024 07:53
sradevski
sradevski reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just one security concern, otherwise LGTM

packages/core/core-flows/src/auth/steps/set-auth-app-metadata.ts Show resolved Hide resolved
packages/medusa/src/api/auth/middlewares.ts Show resolved Hide resolved
packages/core/core-flows/src/auth/workflows/generate-reset-password-token.ts Outdated Show resolved Hide resolved
sradevski
sradevski approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice one, I was someone asking if we'll support resets just today, so timely as well 😄

@sradevski
Copy link
Member

@olivermrbl I'll merge this one so I can do the rebase conflicts

@sradevski sradevski merged commit e27056b into develop Sep 6, 2024
23 checks passed
@sradevski sradevski deleted the feat/reset-password branch September 6, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivermrbl @sradevski @riqwan