Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(order,utils): fix outstanding amount stuck on long orders #8968

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix(order,utils): fix outstanding amount stuck on long orders #8968

merged 2 commits into from
Sep 3, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Sep 3, 2024

what:

When update requests cross the default limit, it doesn't update any records beyond it. This PR fixes the issue generally on the abstract internal service and additionally for the order module when sub-resources cross the default limit.

RESOLVES CC-367

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:05pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 3, 2024 2:05pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 2:05pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 2:05pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 2:05pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 2:05pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 2:05pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5e6cca6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review September 3, 2024 14:03
@riqwan riqwan requested a review from a team as a code owner September 3, 2024 14:03
@riqwan riqwan requested a review from adrien2p September 3, 2024 14:06
riqwan
riqwan commented Sep 3, 2024
View reviewed changes
packages/core/utils/src/modules-sdk/medusa-internal-service.ts
@@ -304,7 +304,7 @@ export function MedusaInternalService<
if (keySelectorForDataOnly.$or.length) {
const entitiesToUpdate = await this.list(
keySelectorForDataOnly,
{},
{ take: null },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc. @adrien2p just so you are aware

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we pass the selector to mikro orm instead of listing first?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we fixed that long time ago 😅

@olivermrbl olivermrbl merged commit ff623f8 into develop Sep 3, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/refunds-fix branch September 3, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom left review comments

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@riqwan @srindom @adrien2p @carlos-r-l-rodrigues @olivermrbl