Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Tab behaviour in DataGrid #8973

Merged
merged 11 commits into from
Sep 3, 2024

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Sep 3, 2024

What

  • Fixes "Tab" behaviour in DataGrid component.
  • Removes FocusTrap dependency, and prop-types dependency as it is no longer needed now that we have removed FocusTrap.
  • Adds hotkeys for moving the focus outside of the grid. Ctrl + Alt + , to move focus to before the grid, and Ctrl + Alt + . to move it to after the grid.

Resolves CC-414, CC-397

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 5:31pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 3, 2024 5:31pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 5:31pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 5:31pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 5:31pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 5:31pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 5:31pm

Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: 39d1d17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kasperkristensen kasperkristensen changed the title fix(dashboard): Focus behaviour in DataGrid fix(dashboard): Tab behaviour in DataGrid Sep 3, 2024
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab behavior works nicely, but I couldn't get the other new keys to work with the instructions provided in the PR description 🤔

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, I don't think that should block the PR necessarily

@kasperkristensen
Copy link
Contributor Author

@olivermrbl should be good now

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasperkristensen kasperkristensen merged commit 58c78a7 into develop Sep 3, 2024
23 checks passed
@kasperkristensen kasperkristensen deleted the fix/data-grid-tab-behaviour branch September 3, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants