-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Tab behaviour in DataGrid #8973
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
…sajs/medusa into fix/data-grid-tab-behaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab behavior works nicely, but I couldn't get the other new keys to work with the instructions provided in the PR description 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I don't think that should block the PR necessarily
@olivermrbl should be good now |
…sajs/medusa into fix/data-grid-tab-behaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
Ctrl + Alt + ,
to move focus to before the grid, andCtrl + Alt + .
to move it to after the grid.Resolves CC-414, CC-397