Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add github authentication provider #8980

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

sradevski
Copy link
Member

@sradevski sradevski commented Sep 4, 2024

There is few breaking changes in this PR, namely:

  1. The Google options got renamed to be more consistent (clientID -> clientId, callbackURL -> callbackUrl)
  2. The successRedirectUrl option was removed from google provider
  3. The auth callback handling changed - It used to redirect to successRedirectUrl with the access_token as a query parameter, and the callbackUrl would point to the backend. The flow now would be to set callbackUrl to a FE path, and within that path call sdk.auth.callback() to login similarly to how emailpass login works.

@sradevski sradevski requested a review from a team as a code owner September 4, 2024 06:20
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 10:43am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 10:43am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 10:43am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 10:43am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 10:43am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 10:43am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 10:43am

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: b69f1ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/auth Patch
@medusajs/types Patch
integration-tests-http Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -1,6 +1,6 @@
export interface GoogleAuthProviderOptions {
clientID: string
clientId: string
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change but I thought it might be better to do it now than later. I don't think many people have used google auth anyway.

@sradevski
Copy link
Member Author

/snapshot-this

Copy link
Contributor

github-actions bot commented Sep 4, 2024

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-sdk@0.0.2-snapshot-20240904063643
yarn add @medusajs/admin-shared@0.0.2-snapshot-20240904063643
yarn add @medusajs/admin-vite-plugin@0.0.2-snapshot-20240904063643
yarn add @medusajs/dashboard@0.0.2-snapshot-20240904063643
yarn add create-medusa-app@1.2.9-snapshot-20240904063643
yarn add @medusajs/medusa-cli@1.3.23-snapshot-20240904063643
yarn add medusa-dev-cli@0.0.33-snapshot-20240904063643
yarn add @medusajs/medusa-oas-cli@1.0.0-snapshot-20240904063643
yarn add @medusajs/core-flows@0.0.10-snapshot-20240904063643
yarn add @medusajs/js-sdk@0.0.2-snapshot-20240904063643
yarn add medusa-test-utils@1.1.45-snapshot-20240904063643
yarn add @medusajs/modules-sdk@1.13.0-snapshot-20240904063643
yarn add @medusajs/orchestration@0.5.8-snapshot-20240904063643
yarn add @medusajs/types@1.12.0-snapshot-20240904063643
yarn add @medusajs/utils@1.12.0-snapshot-20240904063643
yarn add @medusajs/workflows-sdk@0.1.7-snapshot-20240904063643
yarn add @medusajs/icons@1.2.2-snapshot-20240904063643
yarn add @medusajs/ui@3.0.1-snapshot-20240904063643
yarn add @medusajs/ui-preset@1.1.4-snapshot-20240904063643
yarn add @medusajs/framework@0.0.2-snapshot-20240904063643
yarn add @medusajs/medusa@1.20.6-snapshot-20240904063643
yarn add medusa-telemetry@0.0.18-snapshot-20240904063643
yarn add @medusajs/api-key@0.1.3-snapshot-20240904063643
yarn add @medusajs/auth@0.0.4-snapshot-20240904063643
yarn add @medusajs/cache-inmemory@1.8.11-snapshot-20240904063643
yarn add @medusajs/cache-redis@1.9.2-snapshot-20240904063643
yarn add @medusajs/cart@0.0.4-snapshot-20240904063643
yarn add @medusajs/currency@0.1.3-snapshot-20240904063643
yarn add @medusajs/customer@0.0.4-snapshot-20240904063643
yarn add @medusajs/event-bus-local@1.9.9-snapshot-20240904063643
yarn add @medusajs/event-bus-redis@1.8.14-snapshot-20240904063643
yarn add @medusajs/file@0.0.2-snapshot-20240904063643
yarn add @medusajs/fulfillment@0.1.3-snapshot-20240904063643
yarn add @medusajs/inventory-next@0.0.4-snapshot-20240904063643
yarn add @medusajs/link-modules@0.2.12-snapshot-20240904063643
yarn add @medusajs/notification@0.1.3-snapshot-20240904063643
yarn add @medusajs/order@0.1.3-snapshot-20240904063643
yarn add @medusajs/payment@0.0.4-snapshot-20240904063643
yarn add @medusajs/pricing@0.1.13-snapshot-20240904063643
yarn add @medusajs/product@0.3.13-snapshot-20240904063643
yarn add @medusajs/promotion@0.0.5-snapshot-20240904063643
yarn add @medusajs/auth-emailpass@0.0.2-snapshot-20240904063643
yarn add @medusajs/auth-github@0.0.2-snapshot-20240904063643
yarn add @medusajs/auth-google@0.0.2-snapshot-20240904063643
yarn add @medusajs/file-local-next@0.0.3-snapshot-20240904063643
yarn add @medusajs/file-s3@0.0.3-snapshot-20240904063643
yarn add @medusajs/fulfillment-manual@0.0.3-snapshot-20240904063643
yarn add @medusajs/notification-local@0.0.2-snapshot-20240904063643
yarn add @medusajs/notification-sendgrid@0.0.2-snapshot-20240904063643
yarn add @medusajs/payment-stripe@0.0.3-snapshot-20240904063643
yarn add @medusajs/region@0.1.2-snapshot-20240904063643
yarn add @medusajs/sales-channel@0.1.2-snapshot-20240904063643
yarn add @medusajs/stock-location-next@0.0.4-snapshot-20240904063643
yarn add @medusajs/store@0.1.2-snapshot-20240904063643
yarn add @medusajs/tax@0.1.2-snapshot-20240904063643
yarn add @medusajs/user@0.0.4-snapshot-20240904063643
yarn add @medusajs/workflow-engine-inmemory@0.0.5-snapshot-20240904063643
yarn add @medusajs/workflow-engine-redis@0.0.5-snapshot-20240904063643

Latest commit: 2a6be52

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, nice work.

@sradevski
Copy link
Member Author

/snapshot-this

Copy link
Contributor

github-actions bot commented Sep 4, 2024

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-sdk@0.0.2-snapshot-20240904084135
yarn add @medusajs/admin-shared@0.0.2-snapshot-20240904084135
yarn add @medusajs/admin-vite-plugin@0.0.2-snapshot-20240904084135
yarn add @medusajs/dashboard@0.0.2-snapshot-20240904084135
yarn add create-medusa-app@1.2.9-snapshot-20240904084135
yarn add @medusajs/medusa-cli@1.3.23-snapshot-20240904084135
yarn add medusa-dev-cli@0.0.33-snapshot-20240904084135
yarn add @medusajs/medusa-oas-cli@1.0.0-snapshot-20240904084135
yarn add @medusajs/core-flows@0.0.10-snapshot-20240904084135
yarn add @medusajs/js-sdk@0.0.2-snapshot-20240904084135
yarn add medusa-test-utils@1.1.45-snapshot-20240904084135
yarn add @medusajs/modules-sdk@1.13.0-snapshot-20240904084135
yarn add @medusajs/orchestration@0.5.8-snapshot-20240904084135
yarn add @medusajs/types@1.12.0-snapshot-20240904084135
yarn add @medusajs/utils@1.12.0-snapshot-20240904084135
yarn add @medusajs/workflows-sdk@0.1.7-snapshot-20240904084135
yarn add @medusajs/icons@1.2.2-snapshot-20240904084135
yarn add @medusajs/ui@3.0.1-snapshot-20240904084135
yarn add @medusajs/ui-preset@1.1.4-snapshot-20240904084135
yarn add @medusajs/framework@0.0.2-snapshot-20240904084135
yarn add @medusajs/medusa@1.20.6-snapshot-20240904084135
yarn add medusa-telemetry@0.0.18-snapshot-20240904084135
yarn add @medusajs/api-key@0.1.3-snapshot-20240904084135
yarn add @medusajs/auth@0.0.4-snapshot-20240904084135
yarn add @medusajs/cache-inmemory@1.8.11-snapshot-20240904084135
yarn add @medusajs/cache-redis@1.9.2-snapshot-20240904084135
yarn add @medusajs/cart@0.0.4-snapshot-20240904084135
yarn add @medusajs/currency@0.1.3-snapshot-20240904084135
yarn add @medusajs/customer@0.0.4-snapshot-20240904084135
yarn add @medusajs/event-bus-local@1.9.9-snapshot-20240904084135
yarn add @medusajs/event-bus-redis@1.8.14-snapshot-20240904084135
yarn add @medusajs/file@0.0.2-snapshot-20240904084135
yarn add @medusajs/fulfillment@0.1.3-snapshot-20240904084135
yarn add @medusajs/inventory-next@0.0.4-snapshot-20240904084135
yarn add @medusajs/link-modules@0.2.12-snapshot-20240904084135
yarn add @medusajs/notification@0.1.3-snapshot-20240904084135
yarn add @medusajs/order@0.1.3-snapshot-20240904084135
yarn add @medusajs/payment@0.0.4-snapshot-20240904084135
yarn add @medusajs/pricing@0.1.13-snapshot-20240904084135
yarn add @medusajs/product@0.3.13-snapshot-20240904084135
yarn add @medusajs/promotion@0.0.5-snapshot-20240904084135
yarn add @medusajs/auth-emailpass@0.0.2-snapshot-20240904084135
yarn add @medusajs/auth-github@0.0.2-snapshot-20240904084135
yarn add @medusajs/auth-google@0.0.2-snapshot-20240904084135
yarn add @medusajs/file-local-next@0.0.3-snapshot-20240904084135
yarn add @medusajs/file-s3@0.0.3-snapshot-20240904084135
yarn add @medusajs/fulfillment-manual@0.0.3-snapshot-20240904084135
yarn add @medusajs/notification-local@0.0.2-snapshot-20240904084135
yarn add @medusajs/notification-sendgrid@0.0.2-snapshot-20240904084135
yarn add @medusajs/payment-stripe@0.0.3-snapshot-20240904084135
yarn add @medusajs/region@0.1.2-snapshot-20240904084135
yarn add @medusajs/sales-channel@0.1.2-snapshot-20240904084135
yarn add @medusajs/stock-location-next@0.0.4-snapshot-20240904084135
yarn add @medusajs/store@0.1.2-snapshot-20240904084135
yarn add @medusajs/tax@0.1.2-snapshot-20240904084135
yarn add @medusajs/user@0.0.4-snapshot-20240904084135
yarn add @medusajs/workflow-engine-inmemory@0.0.5-snapshot-20240904084135
yarn add @medusajs/workflow-engine-redis@0.0.5-snapshot-20240904084135

Latest commit: 419cf1b

@sradevski
Copy link
Member Author

/snapshot-this

Copy link
Contributor

github-actions bot commented Sep 4, 2024

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-sdk@0.0.2-snapshot-20240904093945
yarn add @medusajs/admin-shared@0.0.2-snapshot-20240904093945
yarn add @medusajs/admin-vite-plugin@0.0.2-snapshot-20240904093945
yarn add @medusajs/dashboard@0.0.2-snapshot-20240904093945
yarn add create-medusa-app@1.2.9-snapshot-20240904093945
yarn add @medusajs/medusa-cli@1.3.23-snapshot-20240904093945
yarn add medusa-dev-cli@0.0.33-snapshot-20240904093945
yarn add @medusajs/medusa-oas-cli@1.0.0-snapshot-20240904093945
yarn add @medusajs/core-flows@0.0.10-snapshot-20240904093945
yarn add @medusajs/js-sdk@0.0.2-snapshot-20240904093945
yarn add medusa-test-utils@1.1.45-snapshot-20240904093945
yarn add @medusajs/modules-sdk@1.13.0-snapshot-20240904093945
yarn add @medusajs/orchestration@0.5.8-snapshot-20240904093945
yarn add @medusajs/types@1.12.0-snapshot-20240904093945
yarn add @medusajs/utils@1.12.0-snapshot-20240904093945
yarn add @medusajs/workflows-sdk@0.1.7-snapshot-20240904093945
yarn add @medusajs/icons@1.2.2-snapshot-20240904093945
yarn add @medusajs/ui@3.0.1-snapshot-20240904093945
yarn add @medusajs/ui-preset@1.1.4-snapshot-20240904093945
yarn add @medusajs/framework@0.0.2-snapshot-20240904093945
yarn add @medusajs/medusa@1.20.6-snapshot-20240904093945
yarn add medusa-telemetry@0.0.18-snapshot-20240904093945
yarn add @medusajs/api-key@0.1.3-snapshot-20240904093945
yarn add @medusajs/auth@0.0.4-snapshot-20240904093945
yarn add @medusajs/cache-inmemory@1.8.11-snapshot-20240904093945
yarn add @medusajs/cache-redis@1.9.2-snapshot-20240904093945
yarn add @medusajs/cart@0.0.4-snapshot-20240904093945
yarn add @medusajs/currency@0.1.3-snapshot-20240904093945
yarn add @medusajs/customer@0.0.4-snapshot-20240904093945
yarn add @medusajs/event-bus-local@1.9.9-snapshot-20240904093945
yarn add @medusajs/event-bus-redis@1.8.14-snapshot-20240904093945
yarn add @medusajs/file@0.0.2-snapshot-20240904093945
yarn add @medusajs/fulfillment@0.1.3-snapshot-20240904093945
yarn add @medusajs/inventory-next@0.0.4-snapshot-20240904093945
yarn add @medusajs/link-modules@0.2.12-snapshot-20240904093945
yarn add @medusajs/notification@0.1.3-snapshot-20240904093945
yarn add @medusajs/order@0.1.3-snapshot-20240904093945
yarn add @medusajs/payment@0.0.4-snapshot-20240904093945
yarn add @medusajs/pricing@0.1.13-snapshot-20240904093945
yarn add @medusajs/product@0.3.13-snapshot-20240904093945
yarn add @medusajs/promotion@0.0.5-snapshot-20240904093945
yarn add @medusajs/auth-emailpass@0.0.2-snapshot-20240904093945
yarn add @medusajs/auth-github@0.0.2-snapshot-20240904093945
yarn add @medusajs/auth-google@0.0.2-snapshot-20240904093945
yarn add @medusajs/file-local-next@0.0.3-snapshot-20240904093945
yarn add @medusajs/file-s3@0.0.3-snapshot-20240904093945
yarn add @medusajs/fulfillment-manual@0.0.3-snapshot-20240904093945
yarn add @medusajs/notification-local@0.0.2-snapshot-20240904093945
yarn add @medusajs/notification-sendgrid@0.0.2-snapshot-20240904093945
yarn add @medusajs/payment-stripe@0.0.3-snapshot-20240904093945
yarn add @medusajs/region@0.1.2-snapshot-20240904093945
yarn add @medusajs/sales-channel@0.1.2-snapshot-20240904093945
yarn add @medusajs/stock-location-next@0.0.4-snapshot-20240904093945
yarn add @medusajs/store@0.1.2-snapshot-20240904093945
yarn add @medusajs/tax@0.1.2-snapshot-20240904093945
yarn add @medusajs/user@0.0.4-snapshot-20240904093945
yarn add @medusajs/workflow-engine-inmemory@0.0.5-snapshot-20240904093945
yarn add @medusajs/workflow-engine-redis@0.0.5-snapshot-20240904093945

Latest commit: 5a097d8

@sradevski sradevski force-pushed the feat/add-github-authentication-provider branch from 4899158 to b69f1ec Compare September 4, 2024 10:40
@sradevski
Copy link
Member Author

/snapshot-this

Copy link
Contributor

github-actions bot commented Sep 4, 2024

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-sdk@0.0.2-snapshot-20240904104726
yarn add @medusajs/admin-shared@0.0.2-snapshot-20240904104726
yarn add @medusajs/admin-vite-plugin@0.0.2-snapshot-20240904104726
yarn add @medusajs/dashboard@0.0.2-snapshot-20240904104726
yarn add create-medusa-app@1.2.9-snapshot-20240904104726
yarn add @medusajs/medusa-cli@1.3.23-snapshot-20240904104726
yarn add medusa-dev-cli@0.0.33-snapshot-20240904104726
yarn add @medusajs/medusa-oas-cli@1.0.0-snapshot-20240904104726
yarn add @medusajs/core-flows@0.0.10-snapshot-20240904104726
yarn add @medusajs/js-sdk@0.0.2-snapshot-20240904104726
yarn add medusa-test-utils@1.1.45-snapshot-20240904104726
yarn add @medusajs/modules-sdk@1.13.0-snapshot-20240904104726
yarn add @medusajs/orchestration@0.5.8-snapshot-20240904104726
yarn add @medusajs/types@1.12.0-snapshot-20240904104726
yarn add @medusajs/utils@1.12.0-snapshot-20240904104726
yarn add @medusajs/workflows-sdk@0.1.7-snapshot-20240904104726
yarn add @medusajs/icons@1.2.2-snapshot-20240904104726
yarn add @medusajs/ui@3.0.1-snapshot-20240904104726
yarn add @medusajs/ui-preset@1.1.4-snapshot-20240904104726
yarn add @medusajs/framework@0.0.2-snapshot-20240904104726
yarn add @medusajs/medusa@1.20.6-snapshot-20240904104726
yarn add medusa-telemetry@0.0.18-snapshot-20240904104726
yarn add @medusajs/api-key@0.1.3-snapshot-20240904104726
yarn add @medusajs/auth@0.0.4-snapshot-20240904104726
yarn add @medusajs/cache-inmemory@1.8.11-snapshot-20240904104726
yarn add @medusajs/cache-redis@1.9.2-snapshot-20240904104726
yarn add @medusajs/cart@0.0.4-snapshot-20240904104726
yarn add @medusajs/currency@0.1.3-snapshot-20240904104726
yarn add @medusajs/customer@0.0.4-snapshot-20240904104726
yarn add @medusajs/event-bus-local@1.9.9-snapshot-20240904104726
yarn add @medusajs/event-bus-redis@1.8.14-snapshot-20240904104726
yarn add @medusajs/file@0.0.2-snapshot-20240904104726
yarn add @medusajs/fulfillment@0.1.3-snapshot-20240904104726
yarn add @medusajs/inventory-next@0.0.4-snapshot-20240904104726
yarn add @medusajs/link-modules@0.2.12-snapshot-20240904104726
yarn add @medusajs/notification@0.1.3-snapshot-20240904104726
yarn add @medusajs/order@0.1.3-snapshot-20240904104726
yarn add @medusajs/payment@0.0.4-snapshot-20240904104726
yarn add @medusajs/pricing@0.1.13-snapshot-20240904104726
yarn add @medusajs/product@0.3.13-snapshot-20240904104726
yarn add @medusajs/promotion@0.0.5-snapshot-20240904104726
yarn add @medusajs/auth-emailpass@0.0.2-snapshot-20240904104726
yarn add @medusajs/auth-github@0.0.2-snapshot-20240904104726
yarn add @medusajs/auth-google@0.0.2-snapshot-20240904104726
yarn add @medusajs/file-local-next@0.0.3-snapshot-20240904104726
yarn add @medusajs/file-s3@0.0.3-snapshot-20240904104726
yarn add @medusajs/fulfillment-manual@0.0.3-snapshot-20240904104726
yarn add @medusajs/notification-local@0.0.2-snapshot-20240904104726
yarn add @medusajs/notification-sendgrid@0.0.2-snapshot-20240904104726
yarn add @medusajs/payment-stripe@0.0.3-snapshot-20240904104726
yarn add @medusajs/region@0.1.2-snapshot-20240904104726
yarn add @medusajs/sales-channel@0.1.2-snapshot-20240904104726
yarn add @medusajs/stock-location-next@0.0.4-snapshot-20240904104726
yarn add @medusajs/store@0.1.2-snapshot-20240904104726
yarn add @medusajs/tax@0.1.2-snapshot-20240904104726
yarn add @medusajs/user@0.0.4-snapshot-20240904104726
yarn add @medusajs/workflow-engine-inmemory@0.0.5-snapshot-20240904104726
yarn add @medusajs/workflow-engine-redis@0.0.5-snapshot-20240904104726

Latest commit: fb83207

@sradevski sradevski merged commit af4f881 into develop Sep 4, 2024
23 checks passed
@sradevski sradevski deleted the feat/add-github-authentication-provider branch September 4, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants