-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add github authentication provider #8980
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: b69f1ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -1,6 +1,6 @@ | |||
export interface GoogleAuthProviderOptions { | |||
clientID: string | |||
clientId: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change but I thought it might be better to do it now than later. I don't think many people have used google auth anyway.
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-sdk@0.0.2-snapshot-20240904063643 yarn add @medusajs/admin-shared@0.0.2-snapshot-20240904063643 yarn add @medusajs/admin-vite-plugin@0.0.2-snapshot-20240904063643 yarn add @medusajs/dashboard@0.0.2-snapshot-20240904063643 yarn add create-medusa-app@1.2.9-snapshot-20240904063643 yarn add @medusajs/medusa-cli@1.3.23-snapshot-20240904063643 yarn add medusa-dev-cli@0.0.33-snapshot-20240904063643 yarn add @medusajs/medusa-oas-cli@1.0.0-snapshot-20240904063643 yarn add @medusajs/core-flows@0.0.10-snapshot-20240904063643 yarn add @medusajs/js-sdk@0.0.2-snapshot-20240904063643 yarn add medusa-test-utils@1.1.45-snapshot-20240904063643 yarn add @medusajs/modules-sdk@1.13.0-snapshot-20240904063643 yarn add @medusajs/orchestration@0.5.8-snapshot-20240904063643 yarn add @medusajs/types@1.12.0-snapshot-20240904063643 yarn add @medusajs/utils@1.12.0-snapshot-20240904063643 yarn add @medusajs/workflows-sdk@0.1.7-snapshot-20240904063643 yarn add @medusajs/icons@1.2.2-snapshot-20240904063643 yarn add @medusajs/ui@3.0.1-snapshot-20240904063643 yarn add @medusajs/ui-preset@1.1.4-snapshot-20240904063643 yarn add @medusajs/framework@0.0.2-snapshot-20240904063643 yarn add @medusajs/medusa@1.20.6-snapshot-20240904063643 yarn add medusa-telemetry@0.0.18-snapshot-20240904063643 yarn add @medusajs/api-key@0.1.3-snapshot-20240904063643 yarn add @medusajs/auth@0.0.4-snapshot-20240904063643 yarn add @medusajs/cache-inmemory@1.8.11-snapshot-20240904063643 yarn add @medusajs/cache-redis@1.9.2-snapshot-20240904063643 yarn add @medusajs/cart@0.0.4-snapshot-20240904063643 yarn add @medusajs/currency@0.1.3-snapshot-20240904063643 yarn add @medusajs/customer@0.0.4-snapshot-20240904063643 yarn add @medusajs/event-bus-local@1.9.9-snapshot-20240904063643 yarn add @medusajs/event-bus-redis@1.8.14-snapshot-20240904063643 yarn add @medusajs/file@0.0.2-snapshot-20240904063643 yarn add @medusajs/fulfillment@0.1.3-snapshot-20240904063643 yarn add @medusajs/inventory-next@0.0.4-snapshot-20240904063643 yarn add @medusajs/link-modules@0.2.12-snapshot-20240904063643 yarn add @medusajs/notification@0.1.3-snapshot-20240904063643 yarn add @medusajs/order@0.1.3-snapshot-20240904063643 yarn add @medusajs/payment@0.0.4-snapshot-20240904063643 yarn add @medusajs/pricing@0.1.13-snapshot-20240904063643 yarn add @medusajs/product@0.3.13-snapshot-20240904063643 yarn add @medusajs/promotion@0.0.5-snapshot-20240904063643 yarn add @medusajs/auth-emailpass@0.0.2-snapshot-20240904063643 yarn add @medusajs/auth-github@0.0.2-snapshot-20240904063643 yarn add @medusajs/auth-google@0.0.2-snapshot-20240904063643 yarn add @medusajs/file-local-next@0.0.3-snapshot-20240904063643 yarn add @medusajs/file-s3@0.0.3-snapshot-20240904063643 yarn add @medusajs/fulfillment-manual@0.0.3-snapshot-20240904063643 yarn add @medusajs/notification-local@0.0.2-snapshot-20240904063643 yarn add @medusajs/notification-sendgrid@0.0.2-snapshot-20240904063643 yarn add @medusajs/payment-stripe@0.0.3-snapshot-20240904063643 yarn add @medusajs/region@0.1.2-snapshot-20240904063643 yarn add @medusajs/sales-channel@0.1.2-snapshot-20240904063643 yarn add @medusajs/stock-location-next@0.0.4-snapshot-20240904063643 yarn add @medusajs/store@0.1.2-snapshot-20240904063643 yarn add @medusajs/tax@0.1.2-snapshot-20240904063643 yarn add @medusajs/user@0.0.4-snapshot-20240904063643 yarn add @medusajs/workflow-engine-inmemory@0.0.5-snapshot-20240904063643 yarn add @medusajs/workflow-engine-redis@0.0.5-snapshot-20240904063643
|
5314a98
to
b57add0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, nice work.
15c12bf
to
af7a6d4
Compare
af7a6d4
to
747276e
Compare
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-sdk@0.0.2-snapshot-20240904084135 yarn add @medusajs/admin-shared@0.0.2-snapshot-20240904084135 yarn add @medusajs/admin-vite-plugin@0.0.2-snapshot-20240904084135 yarn add @medusajs/dashboard@0.0.2-snapshot-20240904084135 yarn add create-medusa-app@1.2.9-snapshot-20240904084135 yarn add @medusajs/medusa-cli@1.3.23-snapshot-20240904084135 yarn add medusa-dev-cli@0.0.33-snapshot-20240904084135 yarn add @medusajs/medusa-oas-cli@1.0.0-snapshot-20240904084135 yarn add @medusajs/core-flows@0.0.10-snapshot-20240904084135 yarn add @medusajs/js-sdk@0.0.2-snapshot-20240904084135 yarn add medusa-test-utils@1.1.45-snapshot-20240904084135 yarn add @medusajs/modules-sdk@1.13.0-snapshot-20240904084135 yarn add @medusajs/orchestration@0.5.8-snapshot-20240904084135 yarn add @medusajs/types@1.12.0-snapshot-20240904084135 yarn add @medusajs/utils@1.12.0-snapshot-20240904084135 yarn add @medusajs/workflows-sdk@0.1.7-snapshot-20240904084135 yarn add @medusajs/icons@1.2.2-snapshot-20240904084135 yarn add @medusajs/ui@3.0.1-snapshot-20240904084135 yarn add @medusajs/ui-preset@1.1.4-snapshot-20240904084135 yarn add @medusajs/framework@0.0.2-snapshot-20240904084135 yarn add @medusajs/medusa@1.20.6-snapshot-20240904084135 yarn add medusa-telemetry@0.0.18-snapshot-20240904084135 yarn add @medusajs/api-key@0.1.3-snapshot-20240904084135 yarn add @medusajs/auth@0.0.4-snapshot-20240904084135 yarn add @medusajs/cache-inmemory@1.8.11-snapshot-20240904084135 yarn add @medusajs/cache-redis@1.9.2-snapshot-20240904084135 yarn add @medusajs/cart@0.0.4-snapshot-20240904084135 yarn add @medusajs/currency@0.1.3-snapshot-20240904084135 yarn add @medusajs/customer@0.0.4-snapshot-20240904084135 yarn add @medusajs/event-bus-local@1.9.9-snapshot-20240904084135 yarn add @medusajs/event-bus-redis@1.8.14-snapshot-20240904084135 yarn add @medusajs/file@0.0.2-snapshot-20240904084135 yarn add @medusajs/fulfillment@0.1.3-snapshot-20240904084135 yarn add @medusajs/inventory-next@0.0.4-snapshot-20240904084135 yarn add @medusajs/link-modules@0.2.12-snapshot-20240904084135 yarn add @medusajs/notification@0.1.3-snapshot-20240904084135 yarn add @medusajs/order@0.1.3-snapshot-20240904084135 yarn add @medusajs/payment@0.0.4-snapshot-20240904084135 yarn add @medusajs/pricing@0.1.13-snapshot-20240904084135 yarn add @medusajs/product@0.3.13-snapshot-20240904084135 yarn add @medusajs/promotion@0.0.5-snapshot-20240904084135 yarn add @medusajs/auth-emailpass@0.0.2-snapshot-20240904084135 yarn add @medusajs/auth-github@0.0.2-snapshot-20240904084135 yarn add @medusajs/auth-google@0.0.2-snapshot-20240904084135 yarn add @medusajs/file-local-next@0.0.3-snapshot-20240904084135 yarn add @medusajs/file-s3@0.0.3-snapshot-20240904084135 yarn add @medusajs/fulfillment-manual@0.0.3-snapshot-20240904084135 yarn add @medusajs/notification-local@0.0.2-snapshot-20240904084135 yarn add @medusajs/notification-sendgrid@0.0.2-snapshot-20240904084135 yarn add @medusajs/payment-stripe@0.0.3-snapshot-20240904084135 yarn add @medusajs/region@0.1.2-snapshot-20240904084135 yarn add @medusajs/sales-channel@0.1.2-snapshot-20240904084135 yarn add @medusajs/stock-location-next@0.0.4-snapshot-20240904084135 yarn add @medusajs/store@0.1.2-snapshot-20240904084135 yarn add @medusajs/tax@0.1.2-snapshot-20240904084135 yarn add @medusajs/user@0.0.4-snapshot-20240904084135 yarn add @medusajs/workflow-engine-inmemory@0.0.5-snapshot-20240904084135 yarn add @medusajs/workflow-engine-redis@0.0.5-snapshot-20240904084135
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-sdk@0.0.2-snapshot-20240904093945 yarn add @medusajs/admin-shared@0.0.2-snapshot-20240904093945 yarn add @medusajs/admin-vite-plugin@0.0.2-snapshot-20240904093945 yarn add @medusajs/dashboard@0.0.2-snapshot-20240904093945 yarn add create-medusa-app@1.2.9-snapshot-20240904093945 yarn add @medusajs/medusa-cli@1.3.23-snapshot-20240904093945 yarn add medusa-dev-cli@0.0.33-snapshot-20240904093945 yarn add @medusajs/medusa-oas-cli@1.0.0-snapshot-20240904093945 yarn add @medusajs/core-flows@0.0.10-snapshot-20240904093945 yarn add @medusajs/js-sdk@0.0.2-snapshot-20240904093945 yarn add medusa-test-utils@1.1.45-snapshot-20240904093945 yarn add @medusajs/modules-sdk@1.13.0-snapshot-20240904093945 yarn add @medusajs/orchestration@0.5.8-snapshot-20240904093945 yarn add @medusajs/types@1.12.0-snapshot-20240904093945 yarn add @medusajs/utils@1.12.0-snapshot-20240904093945 yarn add @medusajs/workflows-sdk@0.1.7-snapshot-20240904093945 yarn add @medusajs/icons@1.2.2-snapshot-20240904093945 yarn add @medusajs/ui@3.0.1-snapshot-20240904093945 yarn add @medusajs/ui-preset@1.1.4-snapshot-20240904093945 yarn add @medusajs/framework@0.0.2-snapshot-20240904093945 yarn add @medusajs/medusa@1.20.6-snapshot-20240904093945 yarn add medusa-telemetry@0.0.18-snapshot-20240904093945 yarn add @medusajs/api-key@0.1.3-snapshot-20240904093945 yarn add @medusajs/auth@0.0.4-snapshot-20240904093945 yarn add @medusajs/cache-inmemory@1.8.11-snapshot-20240904093945 yarn add @medusajs/cache-redis@1.9.2-snapshot-20240904093945 yarn add @medusajs/cart@0.0.4-snapshot-20240904093945 yarn add @medusajs/currency@0.1.3-snapshot-20240904093945 yarn add @medusajs/customer@0.0.4-snapshot-20240904093945 yarn add @medusajs/event-bus-local@1.9.9-snapshot-20240904093945 yarn add @medusajs/event-bus-redis@1.8.14-snapshot-20240904093945 yarn add @medusajs/file@0.0.2-snapshot-20240904093945 yarn add @medusajs/fulfillment@0.1.3-snapshot-20240904093945 yarn add @medusajs/inventory-next@0.0.4-snapshot-20240904093945 yarn add @medusajs/link-modules@0.2.12-snapshot-20240904093945 yarn add @medusajs/notification@0.1.3-snapshot-20240904093945 yarn add @medusajs/order@0.1.3-snapshot-20240904093945 yarn add @medusajs/payment@0.0.4-snapshot-20240904093945 yarn add @medusajs/pricing@0.1.13-snapshot-20240904093945 yarn add @medusajs/product@0.3.13-snapshot-20240904093945 yarn add @medusajs/promotion@0.0.5-snapshot-20240904093945 yarn add @medusajs/auth-emailpass@0.0.2-snapshot-20240904093945 yarn add @medusajs/auth-github@0.0.2-snapshot-20240904093945 yarn add @medusajs/auth-google@0.0.2-snapshot-20240904093945 yarn add @medusajs/file-local-next@0.0.3-snapshot-20240904093945 yarn add @medusajs/file-s3@0.0.3-snapshot-20240904093945 yarn add @medusajs/fulfillment-manual@0.0.3-snapshot-20240904093945 yarn add @medusajs/notification-local@0.0.2-snapshot-20240904093945 yarn add @medusajs/notification-sendgrid@0.0.2-snapshot-20240904093945 yarn add @medusajs/payment-stripe@0.0.3-snapshot-20240904093945 yarn add @medusajs/region@0.1.2-snapshot-20240904093945 yarn add @medusajs/sales-channel@0.1.2-snapshot-20240904093945 yarn add @medusajs/stock-location-next@0.0.4-snapshot-20240904093945 yarn add @medusajs/store@0.1.2-snapshot-20240904093945 yarn add @medusajs/tax@0.1.2-snapshot-20240904093945 yarn add @medusajs/user@0.0.4-snapshot-20240904093945 yarn add @medusajs/workflow-engine-inmemory@0.0.5-snapshot-20240904093945 yarn add @medusajs/workflow-engine-redis@0.0.5-snapshot-20240904093945
|
4899158
to
b69f1ec
Compare
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-sdk@0.0.2-snapshot-20240904104726 yarn add @medusajs/admin-shared@0.0.2-snapshot-20240904104726 yarn add @medusajs/admin-vite-plugin@0.0.2-snapshot-20240904104726 yarn add @medusajs/dashboard@0.0.2-snapshot-20240904104726 yarn add create-medusa-app@1.2.9-snapshot-20240904104726 yarn add @medusajs/medusa-cli@1.3.23-snapshot-20240904104726 yarn add medusa-dev-cli@0.0.33-snapshot-20240904104726 yarn add @medusajs/medusa-oas-cli@1.0.0-snapshot-20240904104726 yarn add @medusajs/core-flows@0.0.10-snapshot-20240904104726 yarn add @medusajs/js-sdk@0.0.2-snapshot-20240904104726 yarn add medusa-test-utils@1.1.45-snapshot-20240904104726 yarn add @medusajs/modules-sdk@1.13.0-snapshot-20240904104726 yarn add @medusajs/orchestration@0.5.8-snapshot-20240904104726 yarn add @medusajs/types@1.12.0-snapshot-20240904104726 yarn add @medusajs/utils@1.12.0-snapshot-20240904104726 yarn add @medusajs/workflows-sdk@0.1.7-snapshot-20240904104726 yarn add @medusajs/icons@1.2.2-snapshot-20240904104726 yarn add @medusajs/ui@3.0.1-snapshot-20240904104726 yarn add @medusajs/ui-preset@1.1.4-snapshot-20240904104726 yarn add @medusajs/framework@0.0.2-snapshot-20240904104726 yarn add @medusajs/medusa@1.20.6-snapshot-20240904104726 yarn add medusa-telemetry@0.0.18-snapshot-20240904104726 yarn add @medusajs/api-key@0.1.3-snapshot-20240904104726 yarn add @medusajs/auth@0.0.4-snapshot-20240904104726 yarn add @medusajs/cache-inmemory@1.8.11-snapshot-20240904104726 yarn add @medusajs/cache-redis@1.9.2-snapshot-20240904104726 yarn add @medusajs/cart@0.0.4-snapshot-20240904104726 yarn add @medusajs/currency@0.1.3-snapshot-20240904104726 yarn add @medusajs/customer@0.0.4-snapshot-20240904104726 yarn add @medusajs/event-bus-local@1.9.9-snapshot-20240904104726 yarn add @medusajs/event-bus-redis@1.8.14-snapshot-20240904104726 yarn add @medusajs/file@0.0.2-snapshot-20240904104726 yarn add @medusajs/fulfillment@0.1.3-snapshot-20240904104726 yarn add @medusajs/inventory-next@0.0.4-snapshot-20240904104726 yarn add @medusajs/link-modules@0.2.12-snapshot-20240904104726 yarn add @medusajs/notification@0.1.3-snapshot-20240904104726 yarn add @medusajs/order@0.1.3-snapshot-20240904104726 yarn add @medusajs/payment@0.0.4-snapshot-20240904104726 yarn add @medusajs/pricing@0.1.13-snapshot-20240904104726 yarn add @medusajs/product@0.3.13-snapshot-20240904104726 yarn add @medusajs/promotion@0.0.5-snapshot-20240904104726 yarn add @medusajs/auth-emailpass@0.0.2-snapshot-20240904104726 yarn add @medusajs/auth-github@0.0.2-snapshot-20240904104726 yarn add @medusajs/auth-google@0.0.2-snapshot-20240904104726 yarn add @medusajs/file-local-next@0.0.3-snapshot-20240904104726 yarn add @medusajs/file-s3@0.0.3-snapshot-20240904104726 yarn add @medusajs/fulfillment-manual@0.0.3-snapshot-20240904104726 yarn add @medusajs/notification-local@0.0.2-snapshot-20240904104726 yarn add @medusajs/notification-sendgrid@0.0.2-snapshot-20240904104726 yarn add @medusajs/payment-stripe@0.0.3-snapshot-20240904104726 yarn add @medusajs/region@0.1.2-snapshot-20240904104726 yarn add @medusajs/sales-channel@0.1.2-snapshot-20240904104726 yarn add @medusajs/stock-location-next@0.0.4-snapshot-20240904104726 yarn add @medusajs/store@0.1.2-snapshot-20240904104726 yarn add @medusajs/tax@0.1.2-snapshot-20240904104726 yarn add @medusajs/user@0.0.4-snapshot-20240904104726 yarn add @medusajs/workflow-engine-inmemory@0.0.5-snapshot-20240904104726 yarn add @medusajs/workflow-engine-redis@0.0.5-snapshot-20240904104726
|
There is few breaking changes in this PR, namely:
clientID
->clientId
,callbackURL
->callbackUrl
)successRedirectUrl
option was removed from google providersuccessRedirectUrl
with theaccess_token
as a query parameter, and thecallbackUrl
would point to the backend. The flow now would be to setcallbackUrl
to a FE path, and within that path callsdk.auth.callback()
to login similarly to how emailpass login works.