Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): add inventory kit info in order summary #8990

Merged
merged 3 commits into from
Sep 5, 2024
Merged

feat(dashboard): add inventory kit info in order summary #8990

merged 3 commits into from
Sep 5, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Sep 4, 2024

What

  • display inventory kit if the items' variant has one

Screenshot 2024-09-04 at 14 12 07

@fPolic fPolic requested a review from a team as a code owner September 4, 2024 12:15
@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 1:08pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 5, 2024 1:08pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 1:08pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 1:08pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 1:08pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 1:08pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 1:08pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7ce344b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic requested a review from olivermrbl September 4, 2024 12:15
@olivermrbl
Copy link
Contributor

Nice LGTM, only one todo: The collapse arrow is inverted

CleanShot.2024-09-04.at.20.33.07.mp4

@kodiakhq kodiakhq bot merged commit c27aa46 into develop Sep 5, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/order-details-inventory-kit branch September 5, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @olivermrbl