-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for refreshing JWT tokens #9013
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
@olivermrbl I think this will cause some merge conflicts with your reset password PR, apologies for that :) |
q: if a token is refreshed 3 times, will all 3 tokens be valid if they're not expired yet? |
@sradevski does this add a last step in the third-party authentication flow to send a request to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one question in there for a scenario
Yes @shahednasser , the code will look like this:
(obviously it's pseudocode-ish) |
1861e4e
to
7e26227
Compare
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@0.0.2-snapshot-20240905140403 yarn add @medusajs/admin-sdk@0.0.2-snapshot-20240905140403 yarn add @medusajs/admin-shared@0.0.2-snapshot-20240905140403 yarn add @medusajs/admin-vite-plugin@0.0.2-snapshot-20240905140403 yarn add @medusajs/dashboard@0.0.2-snapshot-20240905140403 yarn add create-medusa-app@1.2.9-snapshot-20240905140403 yarn add @medusajs/medusa-cli@1.3.23-snapshot-20240905140403 yarn add medusa-dev-cli@0.0.33-snapshot-20240905140403 yarn add @medusajs/medusa-oas-cli@1.0.0-snapshot-20240905140403 yarn add @medusajs/core-flows@0.0.10-snapshot-20240905140403 yarn add @medusajs/js-sdk@0.0.2-snapshot-20240905140403 yarn add medusa-test-utils@1.1.45-snapshot-20240905140403 yarn add @medusajs/modules-sdk@1.13.0-snapshot-20240905140403 yarn add @medusajs/orchestration@0.5.8-snapshot-20240905140403 yarn add @medusajs/types@1.12.0-snapshot-20240905140403 yarn add @medusajs/utils@1.12.0-snapshot-20240905140403 yarn add @medusajs/workflows-sdk@0.1.7-snapshot-20240905140403 yarn add @medusajs/icons@1.2.2-snapshot-20240905140403 yarn add @medusajs/ui@3.0.1-snapshot-20240905140403 yarn add @medusajs/ui-preset@1.1.4-snapshot-20240905140403 yarn add @medusajs/framework@0.0.2-snapshot-20240905140403 yarn add @medusajs/medusa@1.20.6-snapshot-20240905140403 yarn add medusa-telemetry@0.0.18-snapshot-20240905140403 yarn add @medusajs/api-key@0.1.3-snapshot-20240905140403 yarn add @medusajs/auth@0.0.4-snapshot-20240905140403 yarn add @medusajs/cache-inmemory@1.8.11-snapshot-20240905140403 yarn add @medusajs/cache-redis@1.9.2-snapshot-20240905140403 yarn add @medusajs/cart@0.0.4-snapshot-20240905140403 yarn add @medusajs/currency@0.1.3-snapshot-20240905140403 yarn add @medusajs/customer@0.0.4-snapshot-20240905140403 yarn add @medusajs/event-bus-local@1.9.9-snapshot-20240905140403 yarn add @medusajs/event-bus-redis@1.8.14-snapshot-20240905140403 yarn add @medusajs/file@0.0.2-snapshot-20240905140403 yarn add @medusajs/fulfillment@0.1.3-snapshot-20240905140403 yarn add @medusajs/inventory-next@0.0.4-snapshot-20240905140403 yarn add @medusajs/link-modules@0.2.12-snapshot-20240905140403 yarn add @medusajs/notification@0.1.3-snapshot-20240905140403 yarn add @medusajs/order@0.1.3-snapshot-20240905140403 yarn add @medusajs/payment@0.0.4-snapshot-20240905140403 yarn add @medusajs/pricing@0.1.13-snapshot-20240905140403 yarn add @medusajs/product@0.3.13-snapshot-20240905140403 yarn add @medusajs/promotion@0.0.5-snapshot-20240905140403 yarn add @medusajs/auth-emailpass@0.0.2-snapshot-20240905140403 yarn add @medusajs/auth-github@0.0.2-snapshot-20240905140403 yarn add @medusajs/auth-google@0.0.2-snapshot-20240905140403 yarn add @medusajs/file-local-next@0.0.3-snapshot-20240905140403 yarn add @medusajs/file-s3@0.0.3-snapshot-20240905140403 yarn add @medusajs/fulfillment-manual@0.0.3-snapshot-20240905140403 yarn add @medusajs/notification-local@0.0.2-snapshot-20240905140403 yarn add @medusajs/notification-sendgrid@0.0.2-snapshot-20240905140403 yarn add @medusajs/payment-stripe@0.0.3-snapshot-20240905140403 yarn add @medusajs/region@0.1.2-snapshot-20240905140403 yarn add @medusajs/sales-channel@0.1.2-snapshot-20240905140403 yarn add @medusajs/stock-location-next@0.0.4-snapshot-20240905140403 yarn add @medusajs/store@0.1.2-snapshot-20240905140403 yarn add @medusajs/tax@0.1.2-snapshot-20240905140403 yarn add @medusajs/user@0.0.4-snapshot-20240905140403 yarn add @medusajs/workflow-engine-inmemory@0.0.5-snapshot-20240905140403 yarn add @medusajs/workflow-engine-redis@0.0.5-snapshot-20240905140403
|
7e26227
to
d73f4c5
Compare
Nice work, no immediate comments 👍 |
d73f4c5
to
d6f4dad
Compare
This is useful in few scenarios, namely:
expiresIn
hasn't passed.CLOSES CC-425