Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-flows): fixes case where inventory attempts delete when input is empty #9156

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Sep 17, 2024

what:

  • when an empty array is passed to the workflow, it attempts to delete all inventory locations. This PR adds a conditional to prevent it from happening.

RESOLVES CC-477

Fixes #9154

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 7:49am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 17, 2024 7:49am
api-reference-v2 ⬜️ Ignored (Inspect) Sep 17, 2024 7:49am
docs-ui ⬜️ Ignored (Inspect) Sep 17, 2024 7:49am
docs-v2 ⬜️ Ignored (Inspect) Sep 17, 2024 7:49am
medusa-docs ⬜️ Ignored (Inspect) Sep 17, 2024 7:49am
resources-docs ⬜️ Ignored (Inspect) Sep 17, 2024 7:49am

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: 5c4cb72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review September 17, 2024 07:49
@riqwan riqwan requested a review from a team as a code owner September 17, 2024 07:49
@kodiakhq kodiakhq bot merged commit 987d007 into develop Sep 17, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/inventory-deletess branch September 17, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot remove Inventory Levels xxxx. , when select stock location in a inventory item page.
2 participants