Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improvements + additions to workflow docs #9182

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

shahednasser
Copy link
Member

Improve existing workflow docs + add missing docs

@shahednasser shahednasser requested a review from a team as a code owner September 18, 2024 14:19
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:29pm
api-reference-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:29pm
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:29pm
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:29pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:29pm
resources-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:29pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 3:29pm

Copy link

changeset-bot bot commented Sep 18, 2024

⚠️ No Changeset found

Latest commit: 63d3d94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

kodiakhq bot commented Sep 19, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge label Sep 19, 2024
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, added a single comment but otherwise LGTM

@@ -0,0 +1,164 @@
export const metadata = {
Copy link
Contributor

@olivermrbl olivermrbl Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Given we currently have so few API Routes that accept additional data, I think we should do one of two things:

  1. Add the list of all API Routes and reference it here
  2. Hide this for the time being

The reason I suggest 2. is that we need admin extensions before this is really useful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the list of all API Routes and reference it here

Cool idea, I'll do this manually for now but probably worth looking into generating this info (can look into it at another point)

Hide this documentation for the time being

We already use this in the new Customizations chapter 😄 What do you think of adding a note that says you'll be benefit more from this once we add admin extensions soon? (or do we not want to mention it?) Either way, I believe it's generally fine to keep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants