-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improvements + additions to workflow docs #9182
Conversation
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, added a single comment but otherwise LGTM
@@ -0,0 +1,164 @@ | |||
export const metadata = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: Given we currently have so few API Routes that accept additional data, I think we should do one of two things:
- Add the list of all API Routes and reference it here
- Hide this for the time being
The reason I suggest 2. is that we need admin extensions before this is really useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the list of all API Routes and reference it here
Cool idea, I'll do this manually for now but probably worth looking into generating this info (can look into it at another point)
Hide this documentation for the time being
We already use this in the new Customizations chapter 😄 What do you think of adding a note that says you'll be benefit more from this once we add admin extensions soon? (or do we not want to mention it?) Either way, I believe it's generally fine to keep.
Improve existing workflow docs + add missing docs