Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(medusa): list shipping option rules on store endpoint #9192

Closed
wants to merge 6 commits into from
Closed

fix(medusa): list shipping option rules on store endpoint #9192

wants to merge 6 commits into from

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Sep 19, 2024

What

  • return shipping option rules when listing cart options

@fPolic fPolic requested a review from a team as a code owner September 19, 2024 09:43
@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 6:27pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 25, 2024 6:27pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 6:27pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 6:27pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 6:27pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 6:27pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 6:27pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1e4c0ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic mentioned this pull request Sep 19, 2024
Closed
@fPolic fPolic changed the title fix(medusa): list so rules on store endpoint fix(medusa): list shipping option rules on store endpoint Sep 19, 2024
olivermrbl
olivermrbl approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment on the PR to the Next.js starter

@fPolic fPolic marked this pull request as draft September 19, 2024 14:50
@fPolic fPolic marked this pull request as ready for review September 25, 2024 08:25
@fPolic fPolic closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @olivermrbl