Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oas): handle new keys in circular reference patch #9218

Merged
merged 2 commits into from
Sep 22, 2024
Merged

fix(oas): handle new keys in circular reference patch #9218

merged 2 commits into from
Sep 22, 2024

Conversation

shahednasser
Copy link
Member

Handle new keys in the circular references patch leading to undefined not being iterable error.

@shahednasser shahednasser requested a review from a team as a code owner September 20, 2024 14:48
@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 2:50pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 2:50pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Sep 20, 2024 2:50pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 2:50pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 2:50pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 2:50pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 2:50pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: 6cd41ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shahednasser shahednasser mentioned this pull request Sep 20, 2024
Merged
@kodiakhq kodiakhq bot merged commit ba14d43 into develop Sep 22, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/oas-undefined-circ branch September 22, 2024 12:44
kodiakhq bot pushed a commit that referenced this pull request Sep 26, 2024
@shahednasser
oas: [15/n] improve oas schemas (#9216)
97b72f4 
Improve OAS schemas [15/n]

Note: validation error will be fixed once #9218 is merged
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
@shahednasser @panalgin
oas: [15/n] improve oas schemas (medusajs#9216)
ecbbbb4 
Improve OAS schemas [15/n]

Note: validation error will be fixed once medusajs#9218 is merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahednasser @olivermrbl