Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pricing): calculate pricing repository query #9265

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix(pricing): calculate pricing repository query #9265

merged 2 commits into from
Sep 24, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Sep 23, 2024 •
edited
Loading

What

  • fix wrong parentheses nesting when generating calculate pricing query
  • filter out deleted price lists
  • use built in DB values for time comparison

Screenshot 2024-09-23 at 22 18 25
Screenshot 2024-09-23 at 22 05 23

TODO:

  • check after price list start/end_date is modified, PL prices are not retrieved properly anymore

FIXES CC-518

@fPolic fPolic requested a review from a team as a code owner September 23, 2024 20:09
@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 8:10pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 23, 2024 8:10pm
api-reference-v2 ⬜️ Ignored (Inspect) Sep 23, 2024 8:10pm
docs-ui ⬜️ Ignored (Inspect) Sep 23, 2024 8:10pm
docs-v2 ⬜️ Ignored (Inspect) Sep 23, 2024 8:10pm
medusa-docs ⬜️ Ignored (Inspect) Sep 23, 2024 8:10pm
resources-docs ⬜️ Ignored (Inspect) Sep 23, 2024 8:10pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: 2028aae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic requested a review from olivermrbl September 23, 2024 20:10
@kodiakhq kodiakhq bot merged commit d721282 into develop Sep 24, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/pricing-repository-query branch September 24, 2024 10:47
@fPolic fPolic mentioned this pull request Sep 27, 2024
Closed
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
@fPolic @panalgin
fix(pricing): calculate pricing repository query (medusajs#9265)
62cae0d 
**What**
- fix wrong parentheses nesting when generating calculate pricing query
- filter out deleted price lists
- use built in DB values for time comparison

---

![Screenshot 2024-09-23 at 22 18 25](https://github.com/user-attachments/assets/f2fa3891-9dab-4646-947a-50d9a8f937c6)
![Screenshot 2024-09-23 at 22 05 23](https://github.com/user-attachments/assets/7b58b671-6587-4882-800b-275cfcbf369e)

---

TODO:
- [x] check after price list start/end_date is modified, PL prices are not retrieved properly anymore

---

FIXES CC-518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@riqwan riqwan riqwan approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fPolic @riqwan @carlos-r-l-rodrigues @olivermrbl