Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing await when refetching region #9283

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: Add missing await when refetching region #9283

merged 1 commit into from
Sep 24, 2024

Conversation

sradevski
Copy link
Member

@sradevski sradevski commented Sep 24, 2024 •
edited
Loading

FIXES #9280
FIXES #9277

@sradevski sradevski requested a review from a team as a code owner September 24, 2024 14:09
@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 2:13pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 2:13pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 2:13pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 2:13pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 2:13pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 2:13pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 2:13pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ffc43c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kodiakhq kodiakhq bot merged commit bb342d4 into develop Sep 24, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/await-region branch September 24, 2024 14:28
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
@sradevski @panalgin
fix: Add missing await when refetching region (medusajs#9283)
ee9ec4b 
FIXES medusajs#9280 
FIXES medusajs#9277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fPolic fPolic fPolic approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The region update does not wait for the promise to resolve. QueryConfig field typo
2 participants
@sradevski @fPolic