Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dist access for modules in integration tests #9336

Merged
merged 3 commits into from
Sep 27, 2024
Merged

fix: remove dist access for modules in integration tests #9336

merged 3 commits into from
Sep 27, 2024

Conversation

adrien2p
Copy link
Member

What
Integration tests shouldnt access packages dist directly

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f2cdf67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review September 26, 2024 14:09
@adrien2p adrien2p requested a review from a team as a code owner September 26, 2024 14:09
@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 3:04pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 3:04pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 3:04pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 3:04pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 3:04pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 3:04pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 3:04pm

@adrien2p adrien2p merged commit 38778b3 into develop Sep 27, 2024
23 checks passed
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
@adrien2p @panalgin
fix: remove dist access for modules in integration tests (medusajs#9336)
6f50320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @sradevski