Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix server worker mode in railway deployment #9842

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

shahednasser
Copy link
Member

Closes #9835

@shahednasser shahednasser requested a review from a team as a code owner October 28, 2024 14:00
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 8:18am
api-reference-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 8:18am
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 8:18am
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 8:18am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 8:18am
resources-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 8:18am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 8:18am

Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 2463238

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kasperkristensen
Copy link
Contributor

@shahednasser quick question on this guide: Don't we need to update the guide to reflect the changes around standalone builds? Right now I don't believe you would be able to deploy to Railway following these instructions, because you need to run yarn start from the ./medusa/server folder.

I have put some context in this issue TRI-492 ✌️

@shahednasser
Copy link
Member Author

@kasperkristensen thanks for letting me know! Will have to look into it I wasn't aware it would impact deployments. Let me check and look into what needs to be updated

@shahednasser
Copy link
Member Author

@olivermrbl can we get this one in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants