Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-flows,medusa): Include region_id in shipping option retrieval #9929

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

olivermrbl
Copy link
Contributor

What

Include region_id when retrieving shipping options for a cart

Why

Otherwise, region-specific prices will never show in the Store API

Closes CMRC-655 #9906

@olivermrbl olivermrbl requested a review from a team as a code owner November 5, 2024 08:13
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 2:31pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 6, 2024 2:31pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 2:31pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 2:31pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 2:31pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 2:31pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 2:31pm

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: a2dd910

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/medusa Patch
@medusajs/core-flows Patch
@medusajs/types Patch
integration-tests-http Patch
@medusajs/dashboard Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…hub.com:medusajs/medusa into fix/include-region-in-shipping-option-retrieval
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few questions but nothing major :)

olivermrbl and others added 2 commits November 6, 2024 15:01
…pping-options.spec.ts

Co-authored-by: Adrien de Peretti <adrien.deperetti@gmail.com>
…pping-options.spec.ts

Co-authored-by: Adrien de Peretti <adrien.deperetti@gmail.com>
@kodiakhq kodiakhq bot merged commit c1c85ef into develop Nov 6, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/include-region-in-shipping-option-retrieval branch November 6, 2024 15:59
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tax inclusive pricing for shipping options not respecting region's settings
3 participants