Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Prev limit wrong values #9935

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Nov 5, 2024

What
The values are wrongly set which can lead to infinite depth iteration

Note
This will change on how we manage those cases in the future but currently it fixes an issue

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:02pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:02pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:02pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:02pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:02pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:02pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:02pm

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 5b0e5e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review November 5, 2024 11:23
@adrien2p adrien2p requested a review from a team as a code owner November 5, 2024 11:23
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a changeset?

@olivermrbl
Copy link
Contributor

olivermrbl commented Nov 5, 2024

@carlos-r-l-rodrigues, nice catch! We need changesets on all PRs going forward :)

We were discussing a GH action to check if they were missing with @thetutlage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants