fix: Product type tax overrides #9951
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 7 Skipped Deployments
|
|
olivermrbl
force-pushed
the
fix/product-type-tax-override
branch
from
c1fd041 to
ac327e6
Compare
olivermrbl
force-pushed
the
fix/product-type-tax-override
branch
from
ac327e6 to
27cbfee
Compare
| /** | ||
| * The name of the item's product. | ||
| */ | ||
| product_name?: string | ||
|
|
||
| /** | ||
| * The ID of the category of the item's product. | ||
| */ | ||
| product_category_id?: string | ||
|
|
||
| /** | ||
| * The categories of the item's product. | ||
| */ | ||
| product_categories?: string[] | ||
|
|
||
| /** | ||
| * The SKU of the item's product. | ||
| */ | ||
| product_sku?: string | ||
|
|
||
| /** | ||
| * The type of the item's product. | ||
| */ | ||
| product_type?: string | ||
|
|
There was a problem hiding this comment.
These are currently not used for tax calculations so I removed them from the type and input.
| product_name: product.title, | ||
| product_categories: product.categories?.map((c) => c.name), | ||
| // TODO: It is strange that we only accept a single category, revisit the tax module implementation | ||
| product_category_id: product.categories?.[0]?.id, | ||
| product_sku: variant.sku, | ||
| product_type: product.type, |
There was a problem hiding this comment.
These are currently not used for tax calculations so I removed them from the type and input.
| @@ -1,5 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Apparently, a lot of stuff was missing in the cart module snapshot
olivermrbl
requested review from
christiananese,
carlos-r-l-rodrigues and
kasperkristensen
olivermrbl
changed the title
…edusa into fix/product-type-tax-override
What
product_type_idtoorder_line_itemproduct_type_idtocart_line_itemWhy