Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not set default host to localhost #9957

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

thetutlage
Copy link
Contributor

@thetutlage thetutlage commented Nov 6, 2024

Fixes bug introduced by #9912

By default the Node.js server listens on the 0.0.0.0 host. However, the related PR changes the host to localhost and hence resulted in an unwanted breaking change. This PR reverts the default value assignment and let Node.js decide the host when not explicitly specified.

@thetutlage thetutlage requested a review from a team as a code owner November 6, 2024 16:42
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 4:44pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 4:44pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 4:44pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 4:44pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 4:44pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 4:44pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 4:44pm

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 8a35747

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kodiakhq kodiakhq bot merged commit b0f4167 into develop Nov 6, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the fix/default-host branch November 6, 2024 17:04
@olivermrbl
Copy link
Contributor

/snapshot-this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants