Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define ssl options when specified in the connection string #9992

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

thetutlage
Copy link
Contributor

Fixes: FRMW-2770

Currently the db:create command ignores the ssl query string in the connection query string and therefore connections that requires SSL fails.

Also, the command has been updated to connect to the default (same as username) and the postgres database before throwing an error to the user. The code docblocks covers the reason for this behavior.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 0:06am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 8, 2024 0:06am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:06am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:06am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:06am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:06am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:06am

Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: 20df1da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thetutlage thetutlage merged commit 307f101 into develop Nov 8, 2024
23 checks passed
@thetutlage thetutlage deleted the fix/create-db-command branch November 8, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants