Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace decimal separator in order confirmation #425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zaaakher
Copy link
Contributor

@zaaakher zaaakher commented Dec 5, 2024

When my shipping method is $30 for instance, It was $30,00 and this PR fixes it to $30.00

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-starter-medusa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:41pm
storefront-v2-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:41pm

Copy link

vercel bot commented Dec 5, 2024

@zaaakher is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@VariableVic VariableVic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since convertToLocale handles this region-specific logic, we don't need both replace() functions anymore. They're likely leftovers from an earlier version. Could you remove them? I'll merge it in once that's done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants