make LogTable always signed char #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char is signed by default on x86 but unsigned on some arm platforms
but the table needs to contain -1 and this leads to errors like this:
src/component_types/base_packed_component.h: In static member function ‘static unsigned int BasePackedComponent::log2(unsigned int)’:
src/component_types/base_packed_component.h:128:10: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
lkastner
approved these changes
Mar 15, 2023
msoos
approved these changes
Mar 16, 2023
|
WOW that's some seriously good catch! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charissignedby default on x86 butunsignedon some ARM platforms and the table needs to contain -1. This leads to errors like this:This was discovered when building GANAK for julia (Yggdrasil) at JuliaPackaging/Yggdrasil#6393 for the following platforms:
Two more minor fixes that were necessary will follow in separate PRs.
cc: @lkastner