Hide inputs in node inspector for connected ports

[bergie]

As described in noflo/dataflow-noflo#1, in NoFlo (and FBP in general as confirmed by @jpaulm), inports can either:

• Be connected to another port
• Have an IIP assigned to them

This means that dataflow should hide inputs for connected ports. If the original behavior of allowing both IIP and connection is needed for Meemoo, then this should be something that can be configured in dataflow.

Instead of an input, the node inspector should show the connection color for the connected port, and allow disconnecting through a button.

[bergie]

@jpaulm asked for clarification on this issue. In dataflow you have a "node inspector" that you can use to set IIPs for any port of the process. As can be seen from the following screenshot, these input forms are available for all the input ports of the process, not just the ones that don't have a connection (in the screenshot the in port is connected):

For NoFlo, and for simplifying the UI, it would make sense to disable/hide the IIP input fields for those ports that already have an incoming connection. So in this case only the options port would be editable.

[jpaulm]

Thanks for the feedback, Henri! I think I see where you guys came from: from my point of view, it would only make sense to have input forms on the IIPs! They would still be passive, as per FBP (can I say "FBP tradition'?!) and it would be (is?) a fantastic usability feature! I guess you could still optionally hide/reveal the forms on a given IIP - do you do this using mouseovers?

Thanks for the explanation!

PS I don't want to be picky, but black on black doesn't work very well on my screen! This may also be the problem with http://noflo.github.io/noflo-ui/#example/6699161 , which is totally black!

[bergie]

@jpaulm that is the point exactly. If there is a connection, there shouldn't be an input form. If there isn't, then there should be a form where you can enter an IIP.

Note that dataflow doesn't visualize IIPs as their own 'pseudo-nodes', but instead they're only shown with the port that receives them in the node inspector.

[jpaulm]

I think we are agreeing. Just to clarify though - so you would only have
the IIP form where a port has been specified for the component, but has not
been connected, right? If I'm right, it sounds like a great feature!

On Thu, Sep 26, 2013 at 5:01 AM, Henri Bergius notifications@github.comwrote:

@jpaulm https://github.com/jpaulm that is the point exactly. If there
is a connection, there shouldn't be an input form. If there isn't, then
there should be a form where you can enter an IIP.

Note that dataflow doesn't visualize IIPs as their own 'pseudo-nodes', but
instead they're only shown with the port that receives them in the node
inspector.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-25152860
.

[bergie]

@jpaulm yep, that is what this ticket is about. Currently dataflow shows IIP input form for all ports, connected or not. And I'd like to remove these forms for the ports that are connected (and therefore shouldn't be receiving IIPs)

[jpaulm]

Sounds good! What's involved? How many graphics tools are we talking
about?

On Thu, Sep 26, 2013 at 12:00 PM, Henri Bergius notifications@github.comwrote:

@jpaulm https://github.com/jpaulm yep, that is what this ticket is
about. Currently dataflow shows IIP input form for all ports, connected or
not. And I'd like to remove these forms for the ports that are connected
(and therefore shouldn't be receiving IIPs)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-25179950
.

[bergie]

Done! Before connection, you can see two IIP input forms:

After connection you only see one:

[jpaulm]

Very nice! Just a nit, though: why black on black?! Very hard to see on
my screen - you can barely see the form outline!

On Thu, Sep 26, 2013 at 12:35 PM, Henri Bergius notifications@github.comwrote:

Done! Before connection, you can see two IIP input forms:

[image: screenshot 2013-09-26 at 18 34 01]https://f.cloud.github.com/assets/3346/1219332/8399d1f0-26c9-11e3-8653-841c3eb02b0d.png

After connection you only see one:

[image: screenshot 2013-09-26 at 18 33 01]https://f.cloud.github.com/assets/3346/1219336/934d82b8-26c9-11e3-8fe0-f718353851e8.png

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-25182635
.

[forresto]

All the css and visual design is in flux now.