feature: services built from a Dockerfile in parent path

[mpareja]

I've got to hand it to you @darrenmce, the bats tests helped me avoid a regression. Adding a new docker workspace to test out builds was great too!

I need to figure out how to run the tests locally so I don't clumsily bumble my way through setting up the tests correctly.

[mpareja]

My particular use case had a relative path to the dockerfile (../yada). I'll double check that the tests break without my changes. If they dont, I'll update test fixture to encompass my test case.

[mpareja]

Okay, I've updated the test to use a relative path above the directory with the docker-compose file. That's my use case. I have a repository with a bunch of pieces that I then stitch together using Tarantino.

directory structure:

- something
- tarantino
  - docker-compose
  - other-local-specific-config-files
- otherthing

The docker-compose file builds the something and otherthing directories using relative paths.

[darrenmce]

this will fix tt workspace add foo /tmp/bar making containers under the name bar rather than foo?

this is a big one! enforcing sanitised directory names sucks, but we can enforce alias names! (eventually)

[mpareja]

Yes, the container names end up based on the workspace name (which is nice). I think your example is backward, though.

It does, however, mean you'll need to destroy and recreate workspace containers. Might need to do that before upgrading, hmm.

[darrenmce]

yeah meh breaking change is fine, folder and ws is the same name usually anyway

I worded my comment weird, (it's fixing that backwards behavior) but yeah that's what I meant

[darrenmce]

This is awesome, I'm starting to really dig project local tarantino folders

you hid a huge fix in your PR with the -p flag on the dc

[darrenmce]

also my command for running tests locally is, maybe we can add this in to the repo somehow - cuz yeah running the tests actually locally is 😭

docker run --rm -it \
  -v "$PWD:/tt" -v "/var/run/docker.sock:/var/run/docker.sock:ro" -w=/tt \
  darrenmce/tt-test-base \
  sh -c "sudo make install && DEBUG=true bats test/tt_ip.bats; cat debug.log"

also dont forget to install submodules first

git submodule sync
git submodule update --init

[darrenmce]

Ah didn't notice you actually needed that subfolder on the yaml file... yeah remove that last commit I suggested and go for the merge

[mpareja]

This new GitHub feature makes hitting apply from mobile too easy. Going to need to be more responsible in the future. I think the last four commits were probably the worst commit messages I've ever written ...

[mpareja]

Now, if only I could do a mobile revert. Hahaha!

[darrenmce]

haha they actually go down as my commits, yeah it's a cool feature but probably needs a bit more meat to be fully useful (you also can't suggest anything to replace multiple lines - single only)

lol I did the suggest from mobile too.. we are both locked out until we get to desktop

[darrenmce]

removed the last commit, gunna merge after checks pass