Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

feat: extend placeholder builtin with size controls #481

Merged
merged 3 commits into from
May 30, 2018
Merged

feat: extend placeholder builtin with size controls #481

merged 3 commits into from
May 30, 2018

Conversation

tilmx
Copy link
Member

@tilmx tilmx commented May 29, 2018 •
edited
Loading

... so that a placeholder image can be controlled with:

  • min-width + max-width
  • min-height + max-height

Fixes #439

@tilmx tilmx requested a review from marionebl May 29, 2018 22:49
@marionebl marionebl force-pushed the feat/extend-placeholder branch from 07f09f4 to bcbef4d Compare May 30, 2018 14:14
@marionebl marionebl merged commit 7cd8fe5 into master May 30, 2018
@marionebl marionebl deleted the feat/extend-placeholder branch May 30, 2018 14:15
markusoelhafen pushed a commit that referenced this pull request Jun 12, 2018
@tilmx
feat: extend placeholder builtin with size controls (#481)
d2cdafd 
* feat: extend placeholder builtin with size controls

* fix: add width and height props

* fix: adapt to latest api change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marionebl marionebl marionebl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilmx @marionebl