[1.x] RTCP timestamp does not match RTP timestamp on 32bit archs

[Batchyx]

The RTP timestamp is very different from the RTCP timestamp. It works with some clients, but not with others.
I traced it down to some overflow that happens in src/ice.c, in the code that adjusts the RTCP timestamp.

What version of Janus is this happening on?
v1.0.3.

Have you tested a more recent version of Janus too?
c319024.

Was this working before?
No, it didn't work in 0.11.6.

Is there a gdb or libasan trace of the issue?
There is no segfault, but the summary of the gdb trace is:

Thread 17 "hloop 577045851" hit Breakpoint 2, janus_ice_outgoing_rtcp_handle (
    user_data=0x760f80) at src/ice.c:4128
4128    uint32_t s = tv.tv_sec + 2208988800u;
(gdb) p tv
$1 = {tv_sec = 1661421867, tv_usec = 403851}
[advancing to 4139...]
0x00523e28      4139    uint32_t rtp_ts = ((ntp-medium->last_ntp_       ts)*(rtcp_ctx->tb))/1000000 + medium->last_rtp_ts
(gdb) p ntp
$3 = -331707829
(gdb) p medium->last_ntp_ts
$5 = 1661421867392411
(gdb) p medium->last_rtp_ts
$6 = 48960
(gdb) next
[...]
(gdb) p rtp_ts
$7 = 125393835

125393835 is not really comparable to 48960.

Additional context
time_t is 32bit on this os/arch.

[atoppi]

time_t is 32bit on this os/arch

I guess this explains why this evaluation in ice.c

int64_t ntp = tv.tv_sec*G_USEC_PER_SEC + tv.tv_usec;

leads to

(gdb) p ntp
$3 = -331707829

Could you please test again by replacing the mentioned line of ice.c with

int64_t ntp = ((int64_t)tv.tv_sec)*G_USEC_PER_SEC + tv.tv_usec;

[Batchyx]

I tested a similar fix and so far it works. I need to do more tests.

[Batchyx]

After fighting with my still-broken webrtc client, i can confirm that this fixes the problem.

[lminiero]

Thanks for confirming, @atoppi will you push the fix then?

[lminiero]

PS: we'll probably need to do the same on 0.x too.

[atoppi]

fixed by f026b9a (master) and 1fd31e2 (0.x)