Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] update videocall plugin docs to remove/replace apprtc link #3431

Closed
sandeshkhadka opened this issue Sep 20, 2024 · 1 comment
Closed
Labels
multistream Related to Janus 1.x

Comments

@sandeshkhadka
Copy link

What version of Janus is this happening on?
1.3.0

Have you tested a more recent version of Janus too?
Yes

Was this working before?
Yes

Is there a gdb or libasan trace of the issue?
N/A
(https://janus.conf.meetecho.com/docs/debug).

Additional context
I was reading the janus docs and found the apprtc link mentioned in the videocall plugin (https://apprtc.appspot.com) returns 404 error. After visiting apprtc's github I got to know it has been shutdown. It might be good to update the docs to either replace the link with apprtc's github repo(https://github.com/webrtc/apprtc) or simply remove the link.
I can raise a PR if you wish

@sandeshkhadka sandeshkhadka added the multistream Related to Janus 1.x label Sep 20, 2024
@lminiero
Copy link
Member

Thanks for the heads up! No need for a PR, I'll fix it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multistream Related to Janus 1.x
Projects
None yet
Development

No branches or pull requests

2 participants