Tool to convert .mjr files to .pcap #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this introduces a simple tool, part of the post-processing utilities, to convert an existing
.mjrfile to a.pcapreadable, e.g., with Wireshark. Obviously network levels are simulated, and at the moment the timestamp for each packet is fake as well: this still makes the tool useful for inspecting RTP packets in a visual way, and so nice for debugging.We're thinking of modifying the
.mjrformat slightly to include the time at which each specific packet was received. This will be useful for several reasons, one of which would be that such a generated.pcapwould have "real" timing information as well. Not sure yet if I'll just modify this PR for that effort or if that will come later, though.Planning to merge soon, so feedback welcome!