Fix RTSP parsing #2190
Merged
Fix RTSP parsing #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelnicolas
force-pushed
the
bugfix/rtsp-sdp-parsing
branch
from
29c11ae to
d00b7cd
Compare
lminiero
reviewed
Jun 2, 2020
plugins/janus_streaming.c
Outdated
| if(mp->codecs.video_fmtp == NULL) | ||
| mp->codecs.video_fmtp = dovideo ? g_strdup(vfmtp) : NULL; | ||
| mp->codecs.video_fmtp = dovideo && strlen(vfmtp) ? g_strdup(vfmtp) : NULL; |
There was a problem hiding this comment.
Just as a matter of readability, please group the condition in brackets in the 4 lines above.
|
Thanks! I just added a small note, and then it's good to merge for me. |
lionelnicolas
force-pushed
the
bugfix/rtsp-sdp-parsing
branch
from
d00b7cd to
c8ce863
Compare
This ensures that only spaces could be present between format number and format parameters.
This ensures that only spaces could be present between PT and encoding name.
lionelnicolas
force-pushed
the
bugfix/rtsp-sdp-parsing
branch
from
c8ce863 to
f6ef5d8
Compare
|
Thanks, merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues in streaming plugin when pulling an RTSP stream.
When the RTSP server is not sending
fmtpin its SDP, values returned to browsers are wrong because of uninitialized variables :When the RTSP server is sending a incomplete
fmtpline, fmtp parameters where taken from the following line.For example, if RTSP server sends :
The streaming plugin was sending to the browser :