Making the timeout parameters for streaming plugin for RTSP play out configurable

[pontscho]

I found that, the media server which serve stream on RTSP is a little bit buggy and can't possible to change the session timeout for the audio/video stream the connection checking waits too much time. And the timeouts for cURL was also hardcoded. This patch makes this values configurable by both the config file and the controller API.

[januscla]

Thanks for your contribution, @pontscho! Please make sure you sign our CLA, as it's a required step before we can merge this.

[lminiero]

Thanks for your contribution! I added some comments below.

[lminiero]

The code needs fixing too: the automated build failed here,

plugins/janus_streaming.c: In function ‘janus_streaming_create_rtp_source’:
plugins/janus_streaming.c:6057:17: error: ‘janus_streaming_rtp_source’ {aka ‘struct janus_streaming_rtp_source’} has no member named ‘ka_timeout’
 6057 |  live_rtp_source->ka_timeout = 0;

which probably means you're not using #ifdef HAVE_LIBCURL where you should.

[pontscho]

The code needs fixing too: the automated build failed here,

plugins/janus_streaming.c: In function ‘janus_streaming_create_rtp_source’:
plugins/janus_streaming.c:6057:17: error: ‘janus_streaming_rtp_source’ {aka ‘struct janus_streaming_rtp_source’} has no member named ‘ka_timeout’
 6057 |  live_rtp_source->ka_timeout = 0;

which probably means you're not using #ifdef HAVE_LIBCURL where you should.

Yes, you right, I forget to compile this thing without curl.

[lminiero]

Thanks for the quick fixes! I added a couple on notes inline, that are just related to style though, so nothing important. I plan to make some tests with my RTSP camera later today to see if I notice regressions or all still works 👍

[lminiero]

I think the stuff you added to the rtsp-test sample can be removed, as it's already documented on top.

[pontscho]

S***. I've added a wrong config file earlier and I lost in that changes. I've fixed it.

[lminiero]

No problem! 😄 Thanks for the quick fixes!

[lminiero]

Works for me, merging, thanks again! 👍