Add ability to specify recordings folder in AudioBridge #2707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the
enable_recording
feature added by @rajneeshksoni to the AudioBridge plugin in #2674, by adding an additional property, calledrecord_dir
, where you can specify where the.wav
recordings should be stored. It's available both in room creation (API or jcfg file) and when usingenable_recording
: when provided, it makesrecord_file
a relative path. Notice this only impacts.wav
recordings, and not the individual recording via.mjr
that we do support in the AudioBridge: it may make sense to enforce it for those too, but maybe later.Tested briefly but it seems to be working for me, feedback welcome.