Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for custom datachannel options in janus.js #2806

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

sqxieshuai
Copy link
Contributor

No description provided.

@lminiero
Copy link
Member

Thanks! I'll have to check if this can cause issues with Janus, as IIRC we do make some assumptions (e.g., ordered=true) in the Janus core too (sctp.c). Have you checked if the custom datachannel options work as expected for you when you use them?

@sqxieshuai
Copy link
Contributor Author

@lminiero In my business, I use datachannel to send some data that does not depend on reliability, such as heartbeat and speed measurement. After using it for a period of time, no serious problems are found.

@lminiero
Copy link
Member

Thanks, merging then! ✌️

@lminiero lminiero merged commit 3f6015b into meetecho:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants