Added option to print extended header in janus-pp-rec (inspired by #2838) #2858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is inspired by the excellent work @adnanel did in #2838, but using a slightly different approach, and broadening the scope a bit. Specifically, it adds a new command line option to
janus-pp-rec
(-e
or--extended-json
) which, if set, only prints the JSON header, but enriched with information it parses from the MJR file itself. An example (with artificial intendation, since the tool prints compact JSON) is the following:where as you can see, besides the "usual" fields already present in the header, there's a new
extended
object that contains additional information. At the moment, the information I've added are the number of packets in the MJR file, the estimated duration of the recording, the rotations we detected (which was the main purpose of #2838 itself) and, for video files, the resolution changes we detected as well. In the future we may add other information, here, depending on what people think might be useful.Please let me know what you think about this, as I plan to merge soon.