Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for dummy publishers in VideoRoom #2958

Merged
merged 4 commits into from
May 20, 2022
Merged

Support for dummy publishers in VideoRoom #2958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f74bd5c
Support for dummy publishers in VideoRoom
lminiero Apr 26, 2022
efa65cd
Don't count the dummy publisher for the max publishers check
lminiero Apr 29, 2022
3b224d4
New VideoRoom request to combine subscribe and unsubscribe (#2962)
lminiero May 20, 2022
47fb496
Fixed conflicts
lminiero May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions conf/janus.plugin.videoroom.jcfg.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@
# for admin to manage listening only participants. default=false)
# require_e2ee = true|false (whether all participants are required to publish and subscribe
# using end-to-end media encryption, e.g., via Insertable Streams; default=false)
# dummy_publisher = true|false (whether a dummy publisher should be created in this room,
# with one separate m-line for each codec supported in the room; this is
# useful when there's a need to create subscriptions with placeholders
# for some or all m-lines, even when they aren't used yet; default=false)
# dummy_streams = in case dummy_publisher is set to true, array of codecs to offer,
# optionally with a fmtp attribute to match (codec/fmtp properties).
# If not provided, all codecs enabled in the room are offered, with no fmtp.
# Notice that the fmtp is parsed, and only a few codecs are supported.
#}

general: {
Expand Down
4 changes: 4 additions & 0 deletions html/mvideoroomtest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ $(document).ready(function() {
Janus.debug("Got a list of available publishers/feeds:", list);
var sources = null;
for(var f in list) {
if(list[f]["dummy"])
continue;
var id = list[f]["id"];
var display = list[f]["display"];
var streams = list[f]["streams"];
Expand Down Expand Up @@ -230,6 +232,8 @@ $(document).ready(function() {
Janus.debug("Got a list of available publishers/feeds:", list);
var sources = null;
for(var f in list) {
if(list[f]["dummy"])
continue;
var id = list[f]["id"];
var display = list[f]["display"];
var streams = list[f]["streams"];
Expand Down
4 changes: 4 additions & 0 deletions html/screensharingtest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ $(document).ready(function() {
var list = msg["publishers"];
Janus.debug("Got a list of available publishers/feeds:", list);
for(var f in list) {
if(list[f]["dummy"])
continue;
var id = list[f]["id"];
var display = list[f]["display"];
Janus.debug(" >> [" + id + "] " + display);
Expand All @@ -224,6 +226,8 @@ $(document).ready(function() {
var list = msg["publishers"];
Janus.debug("Got a list of available publishers/feeds:", list);
for(var f in list) {
if(list[f]["dummy"])
continue;
var id = list[f]["id"];
var display = list[f]["display"];
Janus.debug(" >> [" + id + "] " + display);
Expand Down
4 changes: 4 additions & 0 deletions html/videoroomtest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ $(document).ready(function() {
var list = msg["publishers"];
Janus.debug("Got a list of available publishers/feeds:", list);
for(var f in list) {
if(list[f]["dummy"])
continue;
var id = list[f]["id"];
var streams = list[f]["streams"];
for(var i in streams) {
Expand Down Expand Up @@ -215,6 +217,8 @@ $(document).ready(function() {
var list = msg["publishers"];
Janus.debug("Got a list of available publishers/feeds:", list);
for(var f in list) {
if(list[f]["dummy"])
continue;
var id = list[f]["id"];
var display = list[f]["display"];
var streams = list[f]["streams"];
Expand Down
4 changes: 4 additions & 0 deletions html/vp9svctest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ $(document).ready(function() {
var list = msg["publishers"];
Janus.debug("Got a list of available publishers/feeds:", list);
for(var f in list) {
if(list[f]["dummy"])
continue;
var id = list[f]["id"];
var display = list[f]["display"];
var streams = list[f]["streams"];
Expand Down Expand Up @@ -204,6 +206,8 @@ $(document).ready(function() {
var list = msg["publishers"];
Janus.debug("Got a list of available publishers/feeds:", list);
for(var f in list) {
if(list[f]["dummy"])
continue;
var id = list[f]["id"];
var display = list[f]["display"];
var streams = list[f]["streams"];
Expand Down
Loading