Add new shared JavaScript file for settings in demos #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, all demos define the server to connect to separately, in the
servervariable. This means that, any time the demos are installed somewhere where theservervariable should be different, all JavaScript files need to be updated accordingly, which is a burden and a chore. This is particulatly true for our own online demos, where changes to the demo code are always a pain to update.This is why I've added a new separate file just for hosting the properties that should be shared instead: at the moment it only contains the address of the Janus backend (
server) and the STUN/TURN servers to use (iceServers), but in the future this may be extended to contain more. I plan to merge soon, as I've only created a PR to have a specific reference for the Changelog: I'll make the same changes to the0.xbranch when this is merged.