-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update type definition #3125
Update type definition #3125
Conversation
Thanks for your contribution, @jerry4718! Please make sure you sign our CLA, as it's a required step before we can merge this. |
There's a lot of changes here. Can you please elaborate on what led you to come up with these changes, and explain them? Thanks! |
I'm trying to encapsulate Janus's functions based on Promise, so I found that some functions are not in the type definition file. I added these changes to my own project, which may be useful for others
…---Original---
From: "Lorenzo ***@***.***>
Date: Wed, Dec 14, 2022 21:44 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [meetecho/janus-gateway] Update type definition (PR #3125)
There's a lot of changes here. Can you please elaborate on what led you to come up with these changes, and explain them? Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Pinging @atoppi as this is beyond my poor JS skills 🤭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort!
I've left some comments.
I am really sorry that I have so many negligence, then I will address these points in detail next, thanks for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now it looks good !
Thanks, merging then! |
Hi We are using Janus in our project with TS so just wanted to know how can use type definition which you defined? Janus is awesome Thanks @lminiero |
No description provided.