Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint whole JS codebase and force tab indentation #3170

Merged
merged 7 commits into from
Feb 27, 2023
Merged

Conversation

atoppi
Copy link
Member

@atoppi atoppi commented Feb 20, 2023

As the title explains, Just fixed all the eslint errors/warnings and enforced the tab indent.

@atoppi atoppi added the multistream Related to Janus 1.x label Feb 20, 2023
@atoppi
Copy link
Member Author

atoppi commented Feb 22, 2023

The rationale for this effort is:

  1. Potentially automate checks in github-actions for all the js files (currently CI is linting only janus.js)
  2. Clear out the output for IDEs with native eslint support, in order not to lose any warning/error from the linter

Copy link
Member

@lminiero lminiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a first quick look at the PR. I can't say I've looked in detail at every single change (I may need to do a second review later on), but these are some things I spotted in this round.

html/screensharingtest.js Outdated Show resolved Hide resolved
html/streamingtest.js Show resolved Hide resolved
html/textroomtest.js Outdated Show resolved Hide resolved
html/textroomtest.js Show resolved Hide resolved
html/textroomtest.js Show resolved Hide resolved
html/textroomtest.js Outdated Show resolved Hide resolved
@lminiero
Copy link
Member

Merging.

@lminiero lminiero merged commit a39ceba into master Feb 27, 2023
@lminiero lminiero deleted the js-lint-fix branch February 27, 2023 16:13
lminiero added a commit that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multistream Related to Janus 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants