-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLI dilution (Multistream) #3423
Conversation
ac13850
to
51fe38a
Compare
Hi @lminiero, I had some git issues so sorry for the mess. Reopening the code for this PR. Thanks |
Your PR still includes the changes to the management of simulcast, which has nothing to do with the main purpose of the patch. I already explained that you can already configure the behaviour per subscriber using the API, and that publisher based APIs for framerate can be done in future efforts. |
@lminiero I'm a bit confused :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few editorial notes. I guess most of them will apply to the 0.x version as well, since they're "twins". Thanks!
"Hi @lminiero, thanks for your comments! All fixed and pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! I still see a couple of minor things to adjust, please see inline.
@lminiero, done, thanks! I believe next time will go smoother! :) |
@lminiero, fixed.. |
Thanks for your work and your patience, merging! |
Implementation of PR #3422 (#3422) for multi-stream
Would love to get your input.
Nati Baratz