Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLI dilution (Multistream) #3423

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Conversation

natikaltura
Copy link
Contributor

Implementation of PR #3422 (#3422) for multi-stream

Would love to get your input.
Nati Baratz

@natikaltura natikaltura changed the title Fix overflow of PLI requests to Publishers PLI dilution (Multistream) Sep 8, 2024
@lminiero lminiero mentioned this pull request Sep 9, 2024
@lminiero lminiero added the multistream Related to Janus 1.x label Oct 8, 2024
@natikaltura natikaltura closed this Nov 7, 2024
@natikaltura
Copy link
Contributor Author

Hi @lminiero,

I had some git issues so sorry for the mess.
Fixed the 2 PR’s.

Reopening the code for this PR.

Thanks

@lminiero
Copy link
Member

Your PR still includes the changes to the management of simulcast, which has nothing to do with the main purpose of the patch. I already explained that you can already configure the behaviour per subscriber using the API, and that publisher based APIs for framerate can be done in future efforts.

@natikaltura
Copy link
Contributor Author

@lminiero I'm a bit confused :)
The changes doesn’t alter any functionality related to simulcast management.
I believe what you're referring to is the log in rtp.c, which simply adds an additional field (Milliseconds) to the log. I find this addition very helpful for tracing PLI handling.
Cheers

Copy link
Member

@lminiero lminiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few editorial notes. I guess most of them will apply to the 0.x version as well, since they're "twins". Thanks!

src/plugins/janus_videoroom.c Outdated Show resolved Hide resolved
src/plugins/janus_videoroom.c Outdated Show resolved Hide resolved
src/plugins/janus_videoroom.c Outdated Show resolved Hide resolved
src/plugins/janus_videoroom.c Outdated Show resolved Hide resolved
src/plugins/janus_videoroom.c Outdated Show resolved Hide resolved
src/plugins/janus_videoroom.c Outdated Show resolved Hide resolved
src/plugins/janus_videoroom.c Outdated Show resolved Hide resolved
src/rtp.c Outdated Show resolved Hide resolved
src/rtp.c Outdated Show resolved Hide resolved
@natikaltura
Copy link
Contributor Author

"Hi @lminiero, thanks for your comments! All fixed and pushed.

Copy link
Member

@lminiero lminiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! I still see a couple of minor things to adjust, please see inline.

src/plugins/janus_videoroom.c Outdated Show resolved Hide resolved
src/rtp.c Outdated Show resolved Hide resolved
@natikaltura
Copy link
Contributor Author

@lminiero, done, thanks! I believe next time will go smoother! :)

@natikaltura
Copy link
Contributor Author

@lminiero, fixed..

@lminiero
Copy link
Member

Thanks for your work and your patience, merging!

@lminiero lminiero merged commit d7f7a57 into meetecho:master Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multistream Related to Janus 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants