Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vim/Nvim plugin related fixes #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Vim/Nvim plugin related fixes #135

wants to merge 3 commits into from

Conversation

enggnr
Copy link
Contributor

@enggnr enggnr commented Dec 27, 2023 •
edited by github-actions bot
Loading

Summary by CodeRabbit

  • Chore: Removed unused GitSync setup and maintenance code from npm-init.js. This change simplifies the configuration process and reduces potential points of failure, improving maintainability.
  • Refactor: Streamlined the export statement in npm-init.js, removing "main", "scripts", and "version" properties. This change does not affect end-user functionality but enhances code readability and maintainability.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2023 •
edited
Loading

Image description CodeRabbit

Walkthrough

The changeset primarily focuses on the removal of a GitSync related code block and an export statement from the npm-init.js file. This simplifies the setup process without impacting the core functionality.

Changes

File Path Summary
home/dot_config/npm/config/npm-init.js Removed GitSync related code and an export statement, simplifying the setup process while maintaining core functionality.

🐇

"In the land of code, where logic intertwines,
A rabbit hopped and tweaked some lines.
GitSync gone, exports no more,
Simplicity we do adore! 🎉"

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

github-actions[bot]
github-actions bot reviewed Dec 27, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 15d4922 and 8c52de4 commits.
Files selected (3)
  • home/.chezmoiexternal.toml.tmpl (1)
  • home/dot_config/shell/exports.sh.tmpl (1)
  • home/dot_config/vim/vimrc (1)
Files ignored due to filter (2)
  • home/dot_config/coc/coc-settings.json
  • software.yml
Files not summarized due to errors (3)
  • home/dot_config/shell/exports.sh.tmpl (nothing obtained from openai)
  • home/dot_config/vim/vimrc (nothing obtained from openai)
  • home/.chezmoiexternal.toml.tmpl (nothing obtained from openai)
Files not reviewed due to errors (3)
  • home/dot_config/shell/exports.sh.tmpl (no response)
  • home/dot_config/vim/vimrc (no response)
  • home/.chezmoiexternal.toml.tmpl (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@ProfessorManhattan
Copy link
Contributor

Hey @enggnr --- I manually merged the changes so far... I notice that when I run:

bash -ci "nvim --headless -c 'quitall'"

I see:

mason.nvim has not been set up. Make sure to set up 'mason' before 'mason-lspconfig'. :h mason-lspconfig-quickstart`

Also, after the command finishes, when I open nvim it shows a bunch of unstyled notifications that say mason-null-ls and a few names. I wonder, is mason-null-ls an issue? There's something null? Anyway, I'd like to finish the entire boot process of nvim headlessly. It looks like vim is configured properly now but nvim needs some work to headlessly install all the mason languages. Also, can we do anything to improve the start-out experience for nvim? I think for starters, we should have the file tree window open by default, with the initial cursor focus on the text file that's open.

Also, is there a better way of running bash -ci "nvim --headless -c 'quitall'"? i.e. can we do it without an interactive Bash session?

@enggnr
Copy link
Contributor Author

enggnr commented Feb 15, 2024

mason.nvim has not been set up. Make sure to set up 'mason' before 'mason-lspconfig'. :h mason-lspconfig-quickstart`

It was caused by the presence of .config/npm/config/npm-init.js file. Removing this fixed the problems. I am trying to find what this files is used for.

Note that even though the console says Mason is installing packages if configured, check status with :Mason, after nvim is opened and you use Mason any time, it installs a bunch of items. There is no background way to do it as far as I could tell. Mason does things in the background and this could be why there is no silent install.

github-actions[bot]
github-actions bot reviewed Feb 15, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 8c52de4 and f46398d commits.
Files selected (1)
  • home/dot_config/npm/config/npm-init.js (1)
Files ignored due to filter (1)
  • home/dot_config/npm/favorites.yml
Files skipped from review due to trivial changes (1)
  • home/dot_config/npm/config/npm-init.js
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@enggnr
Copy link
Contributor Author

enggnr commented Feb 15, 2024

@ProfessorManhattan, this has been addressed. Problem was caused by the file dot_config/npm/config/npm-init.js. I was not able to find what this file does, I've removed that file and dot_config/npm/favourites.yml. If these are needed, we would need to address the failures caused due to these files (mostly the js file).

To show file tree, I've updated the setting in megabyte-labs/AstronVim@2f60dbe.

@ProfessorManhattan
Copy link
Contributor

ProfessorManhattan commented Feb 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@enggnr enggnr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headless Install of VIM Plugins
2 participants
@enggnr @ProfessorManhattan