Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to collect Dubbo and Motan plugin metrics using Prometheus #309

Closed
oewang opened this issue Feb 22, 2023 · 0 comments · Fixed by #310
Closed

Failed to collect Dubbo and Motan plugin metrics using Prometheus #309

oewang opened this issue Feb 22, 2023 · 0 comments · Fixed by #310
Assignees
@oewang

Comments

@oewang
Copy link
Contributor

oewang commented Feb 22, 2023

Describe the bug
The metric tag name "service" defined by the Motan and Dubbo rpc plugins conflicts with the original tag name of Prometheus.

To Reproduce
Steps to reproduce the behavior:

  1. Run a Dubbo client and server or a Motan client and server
  2. Send an rpc request
  3. Check the Prometheus dashboard and find the following error:
    image

Expected behavior
Expect Prometheus to get the metrics properly.

Version
The Easeagent latest version

Configuration

  • EaseAgent Configuration
name=dubbo-server
system=rpc-system
### http server
easeagent.server.enabled=true
easeagent.server.port=9903
# -------------------- plugin global config ---------------------
plugin.observability.global.tracing.enabled=true
### dubbo metric
plugin.observability.dubbo.metric.enabled=true
plugin.observability.dubbo.metric.interval=30
plugin.observability.dubbo.metric.topic=platform-metrics
plugin.observability.dubbo.metric.url=/platform-metrics
plugin.observability.dubbo.metric.appendType=http

Logs

OS and Hardware

Additional context
oewang added a commit to oewang/easeagent that referenced this issue Feb 27, 2023
@oewang
fix: Failed to collect Dubbo and Motan plugin metrics using Prometheus
9778ede 
- Change the label name `service` of the dubbo and motan plugins to
`interface`.
- Refactor code
- Remove unnecessary unit tests

Closes megaease#309
@oewang oewang mentioned this issue Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oewang oewang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Failed to collect Dubbo and Motan plugin metrics using Prometheus oewang/easeagent
1 participant
@oewang