Fix RuntimeWarning: coroutine 'OctopusIntelligentSystem.start' was never awaited #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdcastro
commented
Mar 3, 2024
| @@ -46,7 +46,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry): | |||
| ) | |||
|
|
|||
| try: | |||
| await hass.async_add_executor_job(octopus_system.start) | |||
| await octopus_system.start() | |||
There was a problem hiding this comment.
This is the fix for HASS log messages such as:
2024-02-25 15:05:06.334 WARNING (MainThread) [py.warnings] /usr/local/lib/python3.12/asyncio/base_events.py:1959: RuntimeWarning: coroutine 'OctopusIntelligentSystem.start' was never awaited
handle = self._ready.popleft()
Or:
2024-02-15 19:03:02.926 WARNING (MainThread) [py.warnings] /usr/local/lib/python3.12/asyncio/base_events.py:1975: RuntimeWarning: coroutine 'OctopusIntelligentSystem.start' was never awaited
handle = None # Needed to break cycles when an exception occurs.
The start() method was simply not being called. async_add_executor_job() creates a new thread to run the given function, but it does not expect the function to be asynchronous and does not await it. When not awaited, asynchronous functions like start() are not executed.
| @@ -191,7 +191,7 @@ async def __async_cancel_boost_charge(self, session, account_id: str): | |||
| result = await session.execute(query, variable_values=params, operation_name="deleteBoostCharge") | |||
| return result['deleteBoostCharge'] | |||
|
|
|||
| async def __async_get_accounts(session): | |||
| async def __async_get_accounts(self, session): | |||
There was a problem hiding this comment.
The start() function was not being executed, as it wasn’t awaited. When start() is executed, another issue is uncovered: __async_get_accounts() takes 1 positional argument but 2 were given
2024-02-25 23:25:02.662 ERROR (MainThread) [custom_components.octopus_intelligent.octopus_intelligent_system] Authentication failed : OctopusEnergyGraphQLClient.__async_get_accounts() takes 1 positional argument but 2 were given. You may need to check your token or create a new app in the gardena api and use the new token.
pdcastro
force-pushed
the
issue_28_start_never_awaited
branch
from
d36f405 to
7d6bebf
Compare
megakid
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #28 had already been closed as “hopefully fixed”, but it remained. This PR fixes that issue and another issue that got uncovered by the fix.