Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support in service key resource for both port uid and port id #87

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

MegaportPhilipBrowne
Copy link
Contributor

Contributions

Please read the (Contribution Guidelines)[https://github.com/megaport/megaportgo/wiki/Contributing.md]
prior to lodging Pull Requests (PR).

Description

Please include a summary of the change and which issue is fixed. Please also include any relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contributor Agreement

Lodging this Pull Request (PR) indicates agreement with the project's
(Contributor License Agreement)[https://github.com/megaport/megaportgo/wiki/Megaport_Contributor_Licence_Agreement.md].

Please read the Contributor Licence Agreement (CLA) and affirm your acceptance here:

[I have read an accept the CLA]

NOTE If multiple authors have commited to this PR, each one will need to comment on this PR and
agree to the CLA before this PR can be accepted.

@MegaportPhilipBrowne MegaportPhilipBrowne merged commit 361bf83 into main Dec 4, 2024
2 checks passed
@MegaportPhilipBrowne MegaportPhilipBrowne deleted the fix/serviceKeyId branch December 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants