fix: events emitted on overflow detected/cleared

[adampanger]

Hey! It seems the onOverflowDetected and onOverflowCleared are swapped. Currently, when the animation is running due to overflow, the onOverflowCleared is emitted.

Summary by Sourcery

Fix the event emission logic for overflow detection and clearance by swapping the 'onOverflowDetected' and 'onOverflowCleared' events to ensure they are emitted under the correct conditions.

Bug Fixes:

• Correct the emission of events by swapping 'onOverflowDetected' and 'onOverflowCleared' to their appropriate conditions.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vue3-marquee	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 2, 2024 3:39pm

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request corrects the event emissions for overflow detection and clearance in the vue3-marquee component. The onOverflowDetected and onOverflowCleared events were previously swapped, causing incorrect event emissions during animations. The changes ensure that the correct events are emitted based on the overflow state.

File-Level Changes

Files	Changes
packages/vue3-marquee/src/vue3-marquee.vue	Corrected the event emissions for overflow detection and clearance by swapping the emit calls for onOverflowDetected and onOverflowCleared.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @adampanger - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[megasanjay]

Thank you for catching that!